Remove legacy compile-bytecode and cleanup-pyc - #513
Merged
Conversation
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.1
git worktree add -d .worktree/backport-513-to-release-25.1 origin/release-25.1
cd .worktree/backport-513-to-release-25.1
git switch --create backport-513-to-release-25.1
git cherry-pick -x e0446752fada0208d3bc035b19436a7f15d2a474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the legacy post-install deployment scripts
compile-bytecodeandcleanup-pycalong with the ansible tasks that invoked them. Both scripts are deaChanges
scripts/deploy/cleanup-pyc— Python script that unlinked stray.pycfiles fornoc.*apps when the source was gone.scripts/deploy/compile-bytecode— compiled changed.pyfiles to.pyc; relied on the removed./bin/hgMercurial tool.ansible/noc_roles/noc/tasks/post_install.yml— the only two tasks (Compile bytecode,Cleanup hanging .pyc files) that invoked these scripts.Import post install/import_tasks: "post_install.yml"task fromansible/noc_roles/noc/tasks/main.yml, since the include target no longeRationale
docs/releases/*.md, i.e. "Fix compile-compile-bytecodewas already non-functional because./bin/hg(Mercurial) is absent from the repo; NOC uses git.post_install.ymland itsmain.ymlinclude keeps the ansible role consistent (no dangling include, no empty no-op task file).