Skip to content

Remove legacy compile-bytecode and cleanup-pyc - #513

Merged
dvolodin7 merged 2 commits into
masterfrom
rm-compile-bytecode
Sep 5, 2026
Merged

Remove legacy compile-bytecode and cleanup-pyc#513
dvolodin7 merged 2 commits into
masterfrom
rm-compile-bytecode

Conversation

@dvolodin7

@dvolodin7 dvolodin7 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Remove the legacy post-install deployment scripts compile-bytecode and cleanup-pyc along with the ansible tasks that invoked them. Both scripts are dea

Changes

  • Delete scripts/deploy/cleanup-pyc — Python script that unlinked stray .pyc files for noc.* apps when the source was gone.
  • Delete scripts/deploy/compile-bytecode — compiled changed .py files to .pyc; relied on the removed ./bin/hg Mercurial tool.
  • Delete ansible/noc_roles/noc/tasks/post_install.yml — the only two tasks (Compile bytecode, Cleanup hanging .pyc files) that invoked these scripts.
  • Remove the Import post install / import_tasks: "post_install.yml" task from ansible/noc_roles/noc/tasks/main.yml, since the include target no longe

Rationale

  • No live consumers: a repository-wide search finds these scripts referenced only in historical release-note text (docs/releases/*.md, i.e. "Fix compile-
  • compile-bytecode was already non-functional because ./bin/hg (Mercurial) is absent from the repo; NOC uses git.
  • Removing the now-empty post_install.yml and its main.yml include keeps the ansible role consistent (no dangling include, no empty no-op task file).

@dvolodin7 dvolodin7 added this to the 26.0 milestone Sep 4, 2026
@dvolodin7 dvolodin7 self-assigned this Sep 4, 2026
@dvolodin7 dvolodin7 added the backport release-25.1 Backport changes to release-25.1 label Sep 4, 2026
@github-actions github-actions Bot added the deploy Ansible deploy label Sep 4, 2026
@dvolodin7
dvolodin7 merged commit e044675 into master Sep 5, 2026
1 check passed
@dvolodin7
dvolodin7 deleted the rm-compile-bytecode branch September 5, 2026 14:20
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Backport failed for release-25.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.1
git worktree add -d .worktree/backport-513-to-release-25.1 origin/release-25.1
cd .worktree/backport-513-to-release-25.1
git switch --create backport-513-to-release-25.1
git cherry-pick -x e0446752fada0208d3bc035b19436a7f15d2a474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release-25.1 Backport changes to release-25.1 deploy Ansible deploy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant