Repository navigation
test: the service proxy poller's and the connection dot's tests leave out what is not theirs - #76
Merged
Merged
Conversation
hans-fischer
changed the title
…outlined The owner's alpha walk of 2026-10-22 on v0.38.0 (G16): - AW3, AW19: the window's Escape knew the palette, the notifications, a settings page and the drawer only, so over a dialog it closed the drawer behind it or did nothing. Every overlay now registers what Escape does over it as it shows (escape.go: onEscape, onShown); the window's escape runs the top one's, an overlay without one takes the key. Every Fyne dialog is shown through sh.showDialog (Escape is its Dismiss), a framed dialog hides (its SetOnClosed answers no), the pop-ups, the palette, the notifications, the MCP details and the top bar's menus close. - Fyne hands a key to the focused widget only: the fields of Cogpit's dialogs are types that pass an Escape on (fieldEntry, fieldSelectEntry, fieldCheck, fieldSlider, secretEntry), so Escape cancels a dialog whatever field has the keyboard. - AW4: a list's search is cleared and the table gets the keys; the find bar closes from its fields and from the editor (yamlview's OnEscape). D-57's "any other search" had been the navigator's only. - AW2: Escape on an open dropdown's list takes the keyboard off the field, and a dropdown with the keyboard passes Escape on. - AW1: a closed dropdown draws an entry's outline; the field outline token is raised to 2:1 on every surface in both themes, the wells' and cards' edges keep the old value as colorHairline. TestEveryDialogTakesEscape reads the sources for a dialog or pop-up shown past the mechanism. D-116 and D-104 record the lead's decisions; G16, ui-parity, usage, architecture, conventions and the design language say so.
hans-fischer
force-pushed
the
test/alerting-poll-wait
branch
from
October 22, 2026 15:58
313c07d to
008b159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two flakes from PR #74's race jobs, both test-only:
TestPollerThroughTheServiceProxy(alerting): "2 proxy requests for 2 polls in ~300ms at 50ms". The test slept a fixed 260 ms and then required at least three polls, which a loaded runner does not always fit in. It now waits until the fake Alertmanager has three requests (inside the test's 5 s deadline) and then checks, as before, that every poll sent exactly one proxy request.TestDotClickOpensTheConnectionLog(UI 3/8): "the tile's dot dispatched [{cluster.connectLog …} {ui.setNavigatorRow {"row":"pods"} …}]". The navigator reports its row on its own goroutine when it settles; a report landing after the test read its baseline was counted as the click's. The test now leavesui.setNavigatorRowout of the click's calls.Locally: both tests
-racerepeated (8 and 5 runs) pass;go vetof both packages.