Adds individual source magnifications to the lightcurve output - #17
Merged
Conversation
- Implemented a strict flux conservation sanity check in the plotting module to ensure the sum of source fluxes aligns with the true flux. - Enhanced the plotting functions to optionally display fluxes for two sources. - Updated the lightcurve output to include relative fluxes for both sources in the output files. - Modified the lightcurve generator to compute and store individual source magnifications for binary events. - Adjusted the runner to correctly reference parameter files for binary source cases. (smoke bug) - Expanded the event structure to accommodate magnifications for both sources. - Ensured memory allocation for new source magnification vectors during setup. - Fixed malformed fits files from outputLightcurve.cpp (src bug)
…lux-to-lc Add support for multiple sources in lightcurve generation and plotting
mtpenny
referenced
this pull request
in mtpenny/gulls_mp
Apr 22, 2026
copilot review changes and fast-forward updates on general branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.