feat : 가게 대표 이미지 스케줄링#271
Open
kchaeeun wants to merge 9 commits into
Open
Conversation
zzo3ozz
approved these changes
Jun 25, 2024
Collaborator
There was a problem hiding this comment.
새삼 storeAll 을 보니 서버 부하가 염려스럽네요...!
아무래도 Transcational을 전체 스토어에 걸기에는 가게 양이 너무 많을 것 같아,
차후에 동 별로 끊어서 transactional 처리를 진행하거나 하는 리팩토링이 필요해보입니다!
우선은 스케쥴을 매월 1일, 16일에 진행하도록 변경부탁드려도 될까요?
Collaborator
Author
There was a problem hiding this comment.
엇 새로 커밋하다보니 머지 오류가 생겨서 sign-out 부분이 병합되었는데 큰 문제는 없나요?
Hwater00
approved these changes
Jul 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇을 위한 PR인가요?(: 뒤 설명추가)
변경사항 및 이유
작업 내역
작업 후 기대 동작(스크린샷)
PR 특이 사항
Issue Number
close: #270