Skip to content

Upgrade jackson and jackson-databind to v2.21.2 - #100

Merged
jsvd merged 4 commits into
guyboertje:masterfrom
jsvd:upgrade_jackson_2_29_2
May 12, 2026
Merged

Upgrade jackson and jackson-databind to v2.21.2#100
jsvd merged 4 commits into
guyboertje:masterfrom
jsvd:upgrade_jackson_2_29_2

Conversation

@jsvd

@jsvd jsvd commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator
  • Bump jackson-core, jackson-databind, jackson-module-afterburner to 2.21.2
  • Bump jackson-annotations to 2.21
  • Add jackson_annotations_version to build_info.rb and gemspec
  • Fix deprecated TypeSerializer API in RubyAnySerializer (marked as dead code candidate for future removal)
  • Require JRuby 9.4.14.0 and Java 17 toolchain for builds
  • Fix RubyAnySerializerTest: remove CompatVersion.RUBY1_9, use Ruby.newInstance()
  • Enable surefire tests (skipTests=false)
  • Drop legacy Gson benchmarks and dependency

@jsvd
jsvd force-pushed the upgrade_jackson_2_29_2 branch 2 times, most recently from 7271125 to 774d573 Compare April 20, 2026 13:18
- Bump jackson-core, jackson-databind, jackson-module-afterburner to 2.21.2
- Bump jackson-annotations to 2.21
- Add jackson_annotations_version to build_info.rb and gemspec
- Fix deprecated TypeSerializer API in RubyAnySerializer (marked as
  dead code candidate for future removal)
- Require JRuby 9.4.14.0 and Java 17 toolchain for builds
- Fix RubyAnySerializerTest: remove CompatVersion.RUBY1_9, use Ruby.newInstance()
- Enable surefire tests (skipTests=false)
- Drop legacy Gson benchmarks and dependency
@jsvd
jsvd force-pushed the upgrade_jackson_2_29_2 branch from 774d573 to b73d184 Compare April 20, 2026 14:10
Comment thread changelog.md Outdated

@andsel andsel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left a couple of questions about the code changes.
Do you think should also update the NEWS section in README.md:

07 October 2015 - during serialisation, check and execute `to_json_data` method

Comment thread src/main/java/com/jrjackson/JrJacksonBase.java
Comment thread src/main/java/com/jrjackson/RubyAnySerializer.java

@mashhurs mashhurs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to compile the project with jruby-9.4 as defined in the Mavenfile

rvm install jruby-9.4.14.0
rvm use jruby-9.4.14.0

I have got an error saying that bigdecimal isn't available. It is defined in the gemspec without specifying the version - https://github.com/guyboertje/jrjackson/pull/100/changes#diff-dd679a234034f7fcfc65996e3dcf1be0942c1e3ae190b4ef24ed00d7a367fcd0L21
When I removed the bigdecimal gem dependency from gemspec, it builds w/o issue.

  • Do we need to remove it since jruby provides or specify the version or the issue with my env?
[ERROR] Failed to collect dependencies at rubygems:bigdecimal:gem:[0,): 
No versions available for rubygems:bigdecimal:gem:[0,)
  • Logstash upgraded jruby to 10, is it something we need to also plan upgrade jruby here as well?

Comment thread lib/jrjackson/build_info.rb
@jsvd
jsvd requested review from andsel and mashhurs May 6, 2026 15:53

@andsel andsel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd
jsvd requested a review from andsel May 7, 2026 09:14

@andsel andsel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd
jsvd merged commit ba711db into guyboertje:master May 12, 2026
2 checks passed
@jsvd
jsvd deleted the upgrade_jackson_2_29_2 branch May 12, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants