Skip to content

Story 7-3: KF-004 — update() no-op short-circuit (closes #4) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guycorbaz merged 3 commits into from
Apr 29, 2026
Merged

Story 7-3: KF-004 — update() no-op short-circuit (closes #4) #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
646658c
Story 7-3: KF-004 — update() no-op short-circuit (closes #4)
guycorbaz Apr 29, 2026
647f0a2
Story 7-3: code review Pass 1 — Sonnet×3, 1H+5M+9L → 5 patches (2M+3L…
guycorbaz Apr 29, 2026
c37d791
Story 7-3: code review Pass 2 + closure — Haiku×3, 26→0 patches+26 re…
guycorbaz Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
969 changes: 969 additions & 0 deletions _bmad-output/implementation-artifacts/7-3-kf-004-version-bump-optimization.md
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions _bmad-output/implementation-artifacts/sprint-status.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
# - Dev moves story to 'review', then runs code-review (fresh context, different LLM recommended)

generated: 2026-04-03
last_updated: 2026-04-29 (Story 7-2 done — KF-003 TVA DB-driven config closed après 2 passes code review : Pass 1 Sonnet 25→0>LOW (14 patches + 7 reject/defer + 1 bad_spec), Pass 2 Haiku 0 régression / 23/23 ACs PASS / 3 LOW cosmétiques appliqués. Critère d'arrêt CLAUDE.md atteint après Pass 2. Issue GitHub #3 fermée par commit `closes #3` (story implémentation). // Précédent : Story 7-2 spec créée 2026-04-28, implémentation T1-T8 done même jour. Story 3-7 done après 2 passes code review (Pass 1 Sonnet 12→0 critical, 15 patches ; Pass 2 Haiku/Opus 12→1, -92%, dette KF-019 #47 créée). Story 3-6 « journaux personnalisables » reclassified du backlog Epic 3 vers Epic 15 v0.2 (15-4). **Epic 3 status → done**.)
last_updated: 2026-04-29 (Story 7-3 done — KF-004 closed après 2 passes code review : Pass 1 Sonnet×3 17→5 patches (2M+3L)+12 rejected, Pass 2 Haiku×3 26→0 patches+26 rejected. Critère d'arrêt CLAUDE.md atteint Pass 2 : 0 findings > LOW, Acceptance Auditor Haiku confirme conformité spec, Blind+Edge findings = doublons P1 ou faux positifs vérifiés (rust_decimal scale-insensitive empiriquement, journal_entries ordre correct, zip order-sensitive). Issue #4 fermée par story commit. Issues follow-up #49 (KF-020 SELECT FOR UPDATE Epic 8) + #50 (KF-021 test E2E déterministe race AC #29). // Précédent : Story 7-2 done — KF-003 TVA DB-driven config closed après 2 passes code review : Pass 1 Sonnet 25→0>LOW (14 patches + 7 reject/defer + 1 bad_spec), Pass 2 Haiku 0 régression / 23/23 ACs PASS / 3 LOW cosmétiques appliqués. Critère d'arrêt CLAUDE.md atteint après Pass 2. Issue GitHub #3 fermée par commit `closes #3` (story implémentation). // Story 7-2 spec créée 2026-04-28, implémentation T1-T8 done même jour. Story 3-7 done après 2 passes code review (Pass 1 Sonnet 12→0 critical, 15 patches ; Pass 2 Haiku/Opus 12→1, -92%, dette KF-019 #47 créée). Story 3-6 « journaux personnalisables » reclassified du backlog Epic 3 vers Epic 15 v0.2 (15-4). **Epic 3 status → done**.)
# (Story 6-2 → done 2026-04-20 : PR #25 mergée sur main (squash commit fea684b). Multi-tenant IDOR isolation complète. Migration simplifiée sans DELIMITER (sqlx compatibility). Branch protection ajustée.)
# (Story 6-4 → done 2026-04-17 : PR #18 mergée sur main (squash commit 520e8df). KF-007 e2e blocking waived via step-level continue-on-error, Story 6-5 à créer pour fix avant prod v0.1)
# (Epic 5 Facturation QR Bill clôturé 2026-04-16 — 4 stories done, retro done)
Expand Down Expand Up @@ -126,7 +126,7 @@ development_status:
epic-7: in-progress
7-1-audit-complete-kf-002-multi-tenant: done # KF-002 audit + multi-tenant scoping hardening. 4 review passes (Opus/Sonnet/Haiku cycle), trend 18→11→3→0 findings >LOW, 30 patches applied across passes 5/6/7. Pattern 5 lock-ordering doc added. v0.2 residuals tracked: #43 (deadlock-retry middleware), #44 (fallback UI accounts), #45 (server-side invoice validation).
7-2-kf-003-vat-db-driven-config: done # KF-003 closed 2026-04-29 — 2 passes code review (Pass 1 Sonnet 25→0>LOW + 14 patches + 7 reject/defer + 1 bad_spec ; Pass 2 Haiku 0 régression + 3 LOW cosmétiques). 23/23 ACs PASS. Issue GitHub #3 closed par commit `closes #3`.
7-3-kf-004-version-bump-optimization: backlog # KF-004: version no-op fix
7-3-kf-004-version-bump-optimization: done # KF-004 closed 2026-04-29 — 2 passes code review (Pass 1 Sonnet×3 17→5 patches+12 rejected ; Pass 2 Haiku×3 26→0 patches+26 rejected). Critère d'arrêt CLAUDE.md atteint Pass 2 : 0 findings > LOW, Acceptance Auditor Haiku confirme conformité spec (AC #1-#29 + #28-bis), Blind Hunter et Edge Case Hunter trouvent uniquement doublons P1 (rejets intentionnels race v0.1, alignement Variant A) + faux positifs vérifiés (rust_decimal scale-insensitive, journal_entries no-op order correct, zip order-sensitive). 9 repositories patchés (contacts/products/invoices/accounts/bank_accounts/companies/company_invoice_settings/journal_entries/users) avec helper is_no_op_change + court-circuit. 18 tests sqlx + 6 tests E2E HTTP (AC #19-23+29). Refactoring variant C → A pour companies + users. Issue GitHub #4 fermée par commit `closes #4` (story implémentation). Issues follow-up : [KF-020 #49](https://github.com/guycorbaz/kesh/issues/49) (invoices::update SELECT FOR UPDATE Epic 8 prerequisite), [KF-021 #50](https://github.com/guycorbaz/kesh/issues/50) (test E2E déterministe race REPEATABLE READ AC #29 reclassée Pass 1).
7-4-kf-005-fulltext-search-index: backlog # KF-005: FULLTEXT index on search columns
7-5-kf-008-playwright-selector-fixes: backlog # KF-008: Playwright selector ambiguities (36 tests)
7-6-e2e-selector-refactoring: done # KF-010 (from Story 2-6 review): Refactor getByText() brittle selectors. Mergée 2026-04-24 (PR #29, commit 7c8822d)
Expand Down
Loading
Loading