Skip to content

feat(#2096): add two-pass review strategy for large PRs#73

Open
guyoron1 wants to merge 200 commits into
mainfrom
mirror/2303-2096-two-pass-review-strategy
Open

feat(#2096): add two-pass review strategy for large PRs#73
guyoron1 wants to merge 200 commits into
mainfrom
mirror/2303-2096-two-pass-review-strategy

Conversation

@guyoron1

@guyoron1 guyoron1 commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Mirror of upstream fullsend-ai#2303

Adds a two-pass review strategy for large PRs to improve review quality and coverage.

Benkapner and others added 30 commits June 7, 2026 09:54
@Benkapner @claude
docs(problems): add static analysis layer to testing-agents
92e2d17 
Add a new subsection under "CI pipeline for agent configurations"
elaborating on Step 1 (static analysis). Covers component-level
checks (structural integrity, security patterns, token budget),
setup-level analysis (redundancy detection, dependency validation,
token budget distribution, trigger overlap, dimension scoring),
and optional LLM-based rubric scoring. Presents similarity
techniques as options (TF-IDF, embeddings, LLM-based) rather
than prescribing a single approach. Adds three open questions
on thresholds, lint rule universality, and token budgets.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Benjamin Kapner <bkapner@redhat.com>
@ifireball @cursoragent
feat(install): add --vendor for self-contained workflow and agent assets
436a7f8 
Introduce --vendor to install vendored binaries, reusable workflows,
actions, and agent content. Vendored upstream mirror content is committed
under .defaults/ (same layout as runtime sparse checkout); layered installs
fetch fullsend-ai/fullsend@v0 into .defaults when the marker file is absent.

Reusable workflows use inline workspace preparation and reference infra
from ./.defaults/, matching the pre-vendor layered design. Thin callers
render local reusable paths when --vendor is set.

--fullsend-source pins the source tree for both content and binary
cross-compile; --fullsend-binary remains an explicit ELF override.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
feat(vendor): add manifest-driven cleanup and split analyze reporting
0a0561b 
Write vendor-manifest.yaml on --vendor installs so cleanup and analyze work
without a local fullsend checkout. Workflows analyze stays embed-only;
vendor layer reports presence, manifest alignment, and optional source
alignment via admin analyze --fullsend-source.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix: address remaining PR review nits for vendor work
f19f1e3 
Consolidate thin-stage caller registry, reuse resolved source root for
binary vendoring, reject oversized tar members during extraction, restore
workflows scope comment, fix testing-workflows prose, and introduce
InstallFiles as the canonical collector return type.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(binary): restore download tests dropped in prior commit
32aaf9d 
Re-add the full download_test.go suite and append extractSourceTree size
limit coverage.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(vendor): batch stale cleanup and address review nits
b5baa69 
Delete vendored paths atomically via forge.DeleteFiles, reuse resolved
source root for cross-compile, preserve extracted file modes, and tighten
WouldFix deduplication to exact path matches.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
docs(vendor): note --vendor-fullsend-binary removal without alias
8a9681e 
Document intentional breaking change: old flag callers should use --vendor;
only known usage was e2e, already updated in this branch.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(vendor): restore layer docs and normalize cleanup step messages
0b50f96 
Document VendorBinaryLayer legacy naming, restore Uninstall/Analyze
comments, and use Title Case for stale-cleanup progress messages.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(vendor): single-commit upload and address Bugbot findings
1f678e7 
Batch binary, content, and manifest in one CommitFiles call; validate
manifest version on read; trim leading slash in extractSourceTree; wrap
DeleteFiles ref PATCH in retryOnTransient.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(forge): include mode and type in DeleteFiles tree entries
1881e3b 
Use the existing blob mode from the recursive tree and set type blob
so deletion entries match GitHub Trees API expectations.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
test(forge): assert DeleteFiles tree entry mode and type
88ecef4 
Guard against regressions in delete-entry construction per review.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball
Merge upstream/main into feat/distribution-mode-layered-standalone
0013c75 
Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	internal/forge/fake.go
#	internal/forge/forge.go

Signed-off-by: Barak Korren <bkorren@redhat.com>
@ifireball @cursoragent
fix(vendor): address post-review findings from fullsend-ai-review
893d1af 
Encode CommitFiles tree entries as base64 to preserve ELF binaries,
add tar extract containment check, consolidate stale cleanup with a
manifest/binary quick-check, and deduplicate cleanup between CLI and layer.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball
Merge upstream/main into feat/distribution-mode-layered-standalone
52dc9d2 
Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	action.yml
#	docs/guides/dev/testing-workflows.md

Signed-off-by: Barak Korren <bkorren@redhat.com>
@ifireball @cursoragent
docs: address review feedback on ADR 0046 and testing guide
b7b04f5 
Clarify removed distribution-mode artifacts, drop e2e vendor line, and
document action.yml source-build fallback.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
chore: re-trigger fullsend-ai-review after doc fixes
7d71e38 
Empty commit to re-dispatch review; prior synchronize dispatch was cancelled.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(scaffold): include check-e2e-authorization in vendored infra paths
d330766 
Keep enumerateVendoredPaths aligned with CollectVendoredAssets after
main added the composite action (fullsend-ai#2106); fixes CI parity test.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
docs(forge): note base64 encoding in CommitFiles comment
99ddc9d 
Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(install): combine vendor commit with scaffold and retry enrollmen…
fed552c 
…t dispatch

GitHub Actions may return 422 when repo-maintenance is dispatched immediately
after a separate vendor CommitFiles on a fresh .fullsend repo. Merge scaffold
and vendored assets into one atomic commit and retry dispatch on indexing lag.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(install): wait for workflow registration and activate repo-mainte…
1d3da39 
…nance

Poll GitHub until repo-maintenance.yml is active before dispatch, re-touch
config.yaml after scaffold so the push trigger can run enrollment when
dispatch is still rejected, and fall back to awaiting a push-triggered run.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball @cursoragent
fix(forge): write text files as UTF-8 in CommitFiles, blob API for bi…
73dea45 
…nary

Tree entries with encoding:base64 stored base64 text literally on GitHub,
corrupting YAML workflows and vendor-manifest.yaml. Restore UTF-8 inline
content for text and upload binary via the Git Blob API instead.

Signed-off-by: Barak Korren <bkorren@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ralphbean
docs: add design spec for triage prerequisites action (fullsend-ai#401)
63c27e4 
Design for a new `prerequisites` triage action that replaces `blocked`.
The agent can now express both existing blockers and new issues that need
to be created upstream before progress can happen. Includes allowlist
configuration for cross-repo issue creation and a degraded path when
targets are not authorized.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean
docs: add implementation plan for triage prerequisites action (fullse…
ba99ae3 
…nd-ai#401)

Seven-task plan covering config structs, JSON schema, agent prompt,
post-script, user docs, and caller updates. TDD approach with exact
file paths and code blocks.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean
feat(config): add create_issues allowlist config (fullsend-ai#401)
9a35c91 
Add CreateIssuesConfig and AllowTargets types to both OrgConfig and
PerRepoConfig. NewOrgConfig populates defaults with the org and
fullsend-ai/fullsend. NewPerRepoConfig populates with the target repo
and fullsend-ai/fullsend.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean
refactor: update NewOrgConfig/NewPerRepoConfig callers for create_iss…
d4a394e 
…ues (fullsend-ai#401)

Pass org name and target repo to config constructors so create_issues
defaults are populated at install time.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean
feat(schema): replace blocked with prerequisites action (fullsend-ai#401
e492ac7 
)

Replace the blocked action and blocked_by field with a prerequisites
action containing existing[] and create[] arrays. At least one array
must be non-empty.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean
feat(triage): replace blocked action with prerequisites in agent prom…
b2055cb 
…pt (fullsend-ai#401)

The triage agent can now recommend creating upstream issues via the
prerequisites action's create array, in addition to referencing existing
blockers. Adds hard constraint against emitting sufficient when
prerequisites exist.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean
docs: document prerequisites action and create_issues config (fullsen…
c48a832 
…d-ai#401)

Update triage agent docs to explain the new prerequisites action and the
create_issues.allow_targets configuration surface.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean
feat(triage): handle prerequisites action in post-script (fullsend-ai…
3a44b0c 
…#401)

Replace the blocked handler with prerequisites. The post-script reads
the create_issues allowlist from config.yaml, creates permitted upstream
issues via gh, and includes collapsed draft bodies for disallowed or
failed creates so humans can file them manually.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean
fix(triage): correct label name in agent prompt and remove dead code (f…
6f79d87 
…ullsend-ai#401)

The agent prompt referenced a nonexistent `prerequisites` label when
checking for prior blockers — the post-script actually applies the
`blocked` label. Also removed unused SOURCE_ORG variable from
post-triage.sh.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:52 AM UTC · Completed 3:12 AM UTC
Commit: 73a8f7b · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:15 AM UTC · Completed 3:29 AM UTC
Commit: 73a8f7b · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:32 AM UTC · Completed 3:53 AM UTC
Commit: 73a8f7b · View workflow run →

Refine STD for GH-73: fix schema version, imports, preconditions, PSE…
5731ea2 
… quality [skip ci]

- Downgrade std_version from 2.1-enhanced to 2.0 (matches actual schema)
- Fix metadata counts (unit: 36->37, functional: 9->8, p1: 30->31, p2: 6->5)
- Add 7 missing standard library imports to code_generation_config
- Add STP title to all 11 stub file module comments
- Replace "No special preconditions" with specific statements in 6 stubs
- Fix passive step language in TC-001 to active voice
- Update review report: score 79->90, major findings 8->3
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

/fs-review

QualityFlow and others added 2 commits June 22, 2026 03:58
Add QualityFlow tests for GH-73 [skip ci]
ef64e98
@guyoron1
Clean QualityFlow artifacts for GH-73
ef16b66 
Removes intermediate pipeline artifacts (STP, STD, reviews).
Test files (11) are co-located in source tree with qf_ prefix.
Jira: GH-73
[skip ci]
@guyoron1

guyoron1 commented Jun 22, 2026

Copy link
Copy Markdown
Owner Author

/fs-qf

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:49 AM UTC · Completed 6:10 AM UTC
Commit: 6ead6d0 · View workflow run →

QualityFlow and others added 2 commits June 22, 2026 05:51
Add QualityFlow STP review output for GH-73 [skip ci]
35625b9
@claude
Add QualityFlow STP review and refinement for GH-73 [skip ci]
f06f0bc 
Refined STP from NEEDS_REVISION to APPROVED_WITH_FINDINGS (score 58→91).
Added Section I (pre-test analysis), Section II (test planning with scope,
strategy, environment), rewrote 13 generic scenarios, added 12 new scenarios
including two-pass orchestration coverage.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:13 AM UTC · Completed 6:33 AM UTC
Commit: 6ead6d0 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 6:36 AM UTC · Completed 7:14 AM UTC
Commit: 6ead6d0 · View workflow run →

QualityFlow and others added 3 commits June 22, 2026 06:37
fix(std): correct summary priority and test_type counts for GH-73
3390084 
The STD summary.by_priority and summary.by_test_type counts were
inconsistent with the actual scenario data. Updated to match verified
counts: P0=41, P1=46, P2=11 and unit=84, integration=11.

Add QualityFlow output for GH-73 [skip ci]
Add QualityFlow tests for GH-73 [skip ci]
890c7eb
@guyoron1
Clean QualityFlow artifacts for GH-73
c28b1a0 
Removes intermediate pipeline artifacts (STP, STD, reviews).
Test files (22) are co-located in source tree with qf_ prefix.
Jira: GH-73
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@guyoron1 @Benkapner @ifireball @ralphbean @jhutar @ggallen @rh-hemartin @ascerra @waynesun09