fix(#2432): retry merge on 409 after updating PR branch by guyoron1 · Pull Request #75 · guyoron1/fullsend

guyoron1 · 2026-06-21T14:42:36Z

Retries merge operations on 409 conflict after updating the PR branch.

Introduce --vendor to install vendored binaries, reusable workflows, actions, and agent content. Vendored upstream mirror content is committed under .defaults/ (same layout as runtime sparse checkout); layered installs fetch fullsend-ai/fullsend@v0 into .defaults when the marker file is absent. Reusable workflows use inline workspace preparation and reference infra from ./.defaults/, matching the pre-vendor layered design. Thin callers render local reusable paths when --vendor is set. --fullsend-source pins the source tree for both content and binary cross-compile; --fullsend-binary remains an explicit ELF override. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Write vendor-manifest.yaml on --vendor installs so cleanup and analyze work without a local fullsend checkout. Workflows analyze stays embed-only; vendor layer reports presence, manifest alignment, and optional source alignment via admin analyze --fullsend-source. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Consolidate thin-stage caller registry, reuse resolved source root for binary vendoring, reject oversized tar members during extraction, restore workflows scope comment, fix testing-workflows prose, and introduce InstallFiles as the canonical collector return type. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Re-add the full download_test.go suite and append extractSourceTree size limit coverage. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Delete vendored paths atomically via forge.DeleteFiles, reuse resolved source root for cross-compile, preserve extracted file modes, and tighten WouldFix deduplication to exact path matches. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Document intentional breaking change: old flag callers should use --vendor; only known usage was e2e, already updated in this branch. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Document VendorBinaryLayer legacy naming, restore Uninstall/Analyze comments, and use Title Case for stale-cleanup progress messages. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Batch binary, content, and manifest in one CommitFiles call; validate manifest version on read; trim leading slash in extractSourceTree; wrap DeleteFiles ref PATCH in retryOnTransient. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Use the existing blob mode from the recursive tree and set type blob so deletion entries match GitHub Trees API expectations. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Guard against regressions in delete-entry construction per review. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # internal/forge/fake.go # internal/forge/forge.go Signed-off-by: Barak Korren <bkorren@redhat.com>

Encode CommitFiles tree entries as base64 to preserve ELF binaries, add tar extract containment check, consolidate stale cleanup with a manifest/binary quick-check, and deduplicate cleanup between CLI and layer. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # action.yml # docs/guides/dev/testing-workflows.md Signed-off-by: Barak Korren <bkorren@redhat.com>

Clarify removed distribution-mode artifacts, drop e2e vendor line, and document action.yml source-build fallback. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Empty commit to re-dispatch review; prior synchronize dispatch was cancelled. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Keep enumerateVendoredPaths aligned with CollectVendoredAssets after main added the composite action (fullsend-ai#2106); fixes CI parity test. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

…t dispatch GitHub Actions may return 422 when repo-maintenance is dispatched immediately after a separate vendor CommitFiles on a fresh .fullsend repo. Merge scaffold and vendored assets into one atomic commit and retry dispatch on indexing lag. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

…nance Poll GitHub until repo-maintenance.yml is active before dispatch, re-touch config.yaml after scaffold so the push trigger can run enrollment when dispatch is still rejected, and fall back to awaiting a push-triggered run. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

…nary Tree entries with encoding:base64 stored base64 text literally on GitHub, corrupting YAML workflows and vendor-manifest.yaml. Restore UTF-8 inline content for text and upload binary via the Git Blob API instead. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Design for a new `prerequisites` triage action that replaces `blocked`. The agent can now express both existing blockers and new issues that need to be created upstream before progress can happen. Includes allowlist configuration for cross-repo issue creation and a degraded path when targets are not authorized. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

…nd-ai#401) Seven-task plan covering config structs, JSON schema, agent prompt, post-script, user docs, and caller updates. TDD approach with exact file paths and code blocks. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

Add CreateIssuesConfig and AllowTargets types to both OrgConfig and PerRepoConfig. NewOrgConfig populates defaults with the org and fullsend-ai/fullsend. NewPerRepoConfig populates with the target repo and fullsend-ai/fullsend. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

…ues (fullsend-ai#401) Pass org name and target repo to config constructors so create_issues defaults are populated at install time. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

) Replace the blocked action and blocked_by field with a prerequisites action containing existing[] and create[] arrays. At least one array must be non-empty. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

…pt (fullsend-ai#401) The triage agent can now recommend creating upstream issues via the prerequisites action's create array, in addition to referencing existing blockers. Adds hard constraint against emitting sufficient when prerequisites exist. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

…d-ai#401) Update triage agent docs to explain the new prerequisites action and the create_issues.allow_targets configuration surface. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

…#401) Replace the blocked handler with prerequisites. The post-script reads the create_issues allowlist from config.yaml, creates permitted upstream issues via gh, and includes collapsed draft bodies for disallowed or failed creates so humans can file them manually. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

…ullsend-ai#401) The agent prompt referenced a nonexistent `prerequisites` label when checking for prior blockers — the post-script actually applies the `blocked` label. Also removed unused SOURCE_ORG variable from post-triage.sh. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

…end-ai#401) Replace the four blocked-action test cases with five prerequisites-action test cases that exercise the new schema (existing[], create[], allowlist validation). Set up GITHUB_WORKSPACE with a config.yaml fixture and add a mock gh issue-create handler that returns a fake URL. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>

fullsend-ai-review · 2026-06-21T15:13:30Z

🤖 Finished Review · ✅ Success · Started 3:13 PM UTC · Completed 3:30 PM UTC
Commit: 0535520 · View workflow run →

STD generation complete: - STD YAML: outputs/std/fullsend-aiGH-2432/GH-2432_test_description.yaml (13 scenarios) - Go stubs: outputs/std/fullsend-aiGH-2432/go-tests/ (10 functional + 3 E2E) - Pipeline state: outputs/state/fullsend-aiGH-2432/pipeline_state.yaml

fullsend-ai-review · 2026-06-21T15:30:12Z

/fs-review

fullsend-ai-review · 2026-06-21T15:37:00Z

🤖 Finished Review · ✅ Success · Started 3:36 PM UTC · Completed 3:53 PM UTC
Commit: 0535520 · View workflow run →

STD refined from NEEDS_REVISION to APPROVED in 2 iterations. Resolved 5 CRITICAL and 4 MAJOR findings: - Added tier, patterns, variables, test_structure, code_structure to all 13 scenarios - Removed banned related_prs from metadata - Fixed E2E stub package (github -> admin) - Added errors import for context cancellation test - Clarified retry count semantics - Added [NEGATIVE] tags to context cancellation stubs

fullsend-ai-review · 2026-06-21T15:53:05Z

/fs-review

Replaces intermediate pipeline artifacts with organized test files. Total: 2 test files → qf-tests/fullsend-aiGH-2432/ Jira: fullsend-aiGH-2432 [skip ci]

github-actions · 2026-06-21T15:55:33Z

QualityFlow Pipeline Summary

Stage	Agent	Status
1	STP Builder	✅
2	STP Reviewer	✅
3	STP Refiner	✅
4	STD Builder	✅
5	STD Reviewer	✅
6	STD Refiner	✅
7	Test Generator	✅

Test Output

Language	Count	Location
Go	1 files	`internal/forge/github/qf_*_test.go`

Issue: GH-75

Generated by QualityFlow

guyoron1 · 2026-06-22T06:45:17Z

/fs-qf

fullsend-ai-review · 2026-06-22T06:59:52Z

🤖 Finished Review · ✅ Success · Started 6:59 AM UTC · Completed 7:18 AM UTC
Commit: 6ead6d0 · View workflow run →

fullsend-ai-review · 2026-06-22T07:18:52Z

/fs-review

fullsend-ai-review · 2026-06-22T07:21:46Z

🤖 Finished Review · ✅ Success · Started 7:21 AM UTC · Completed 7:38 AM UTC
Commit: 6ead6d0 · View workflow run →

- Refined STD YAML: removed related_prs from metadata, adjusted assertion priorities - Updated Go stub PSE with expanded Steps context - Added STD review report (APPROVED)

fullsend-ai-review · 2026-06-22T07:38:20Z

/fs-review

fullsend-ai-review · 2026-06-22T07:41:27Z

🤖 Finished Review · ✅ Success · Started 7:41 AM UTC · Completed 8:16 AM UTC
Commit: 6ead6d0 · View workflow run →

Removes intermediate pipeline artifacts (STP, STD, reviews). Test files (1) are co-located in source tree with qf_ prefix. Jira: GH-75 [skip ci]

fullsend-ai-review

See the review comment for full details.

fullsend-ai-review · 2026-06-22T08:16:35Z

+      run: "$GITHUB_ACTION_PATH/.github/scripts/install-openshell.sh"

    - name: Restore cached sandbox image
      id: sandbox-cache


[medium] supply-chain

OpenShell CLI installed via curl | sh pattern. The install script URL is pinned to a commit SHA, but the script itself may download additional binary artifacts without hash verification.

Suggested fix: Verify that install.sh pins downloaded binaries by checksum, or download the binary directly with SHA256 verification.

fullsend-ai-review · 2026-06-22T08:16:35Z

+// DeleteFiles atomically removes paths from the repository default branch.
+func (c *LiveClient) DeleteFiles(ctx context.Context, owner, repo, message string, paths []string) (int, error) {
+	if len(paths) == 0 {
+		return 0, nil


[low] edge-case

blobSHA uses SHA-1 for Git blob hashes. SHA-256 repositories would have mismatched hashes causing unnecessary commits. Practical risk is very low.

Co-located tests (qf_* prefix) are now in source package directories. The qf-tests/ directory contained non-compiling tests from the old pipeline.

fullsend-ai-review · 2026-06-22T08:33:00Z

🤖 Finished Review · ✅ Success · Started 8:32 AM UTC · Completed 9:14 AM UTC
Commit: 6ead6d0 · View workflow run →

fullsend-ai-review

See the review comment for full details.

ifireball and others added 30 commits June 10, 2026 16:18

fix(binary): restore download tests dropped in prior commit

32aaf9d

Re-add the full download_test.go suite and append extractSourceTree size limit coverage. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

fix(forge): include mode and type in DeleteFiles tree entries

1881e3b

Use the existing blob mode from the recursive tree and set type blob so deletion entries match GitHub Trees API expectations. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

test(forge): assert DeleteFiles tree entry mode and type

88ecef4

Guard against regressions in delete-entry construction per review. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Merge upstream/main into feat/distribution-mode-layered-standalone

0013c75

Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # internal/forge/fake.go # internal/forge/forge.go Signed-off-by: Barak Korren <bkorren@redhat.com>

Merge upstream/main into feat/distribution-mode-layered-standalone

52dc9d2

Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # action.yml # docs/guides/dev/testing-workflows.md Signed-off-by: Barak Korren <bkorren@redhat.com>

docs: address review feedback on ADR 0046 and testing guide

b7b04f5

Clarify removed distribution-mode artifacts, drop e2e vendor line, and document action.yml source-build fallback. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

chore: re-trigger fullsend-ai-review after doc fixes

7d71e38

Empty commit to re-dispatch review; prior synchronize dispatch was cancelled. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

docs(forge): note base64 encoding in CommitFiles comment

99ddc9d

Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Add STP output for fullsend-aiGH-2432 [skip ci]

9ebf743

QualityFlow added 2 commits June 21, 2026 15:16

Add QualityFlow STP review output for fullsend-aiGH-2432 [skip ci]

cbd6608

QualityFlow added 2 commits June 21, 2026 15:37

Add QualityFlow output for fullsend-aiGH-2432 [skip ci]

727d85b

QualityFlow and others added 2 commits June 21, 2026 15:55

Add test output for fullsend-aiGH-2432 [skip ci]

bf47e6b

Add QualityFlow tests for fullsend-aiGH-2432

269cd6e

Replaces intermediate pipeline artifacts with organized test files. Total: 2 test files → qf-tests/fullsend-aiGH-2432/ Jira: fullsend-aiGH-2432 [skip ci]

QualityFlow added 2 commits June 22, 2026 06:56

Add QualityFlow output for GH-75 [skip ci]

fb7c47c

Add STP output for GH-75 [skip ci]

d9e64c5

Add QualityFlow output for GH-75 [skip ci]

149c632

Add QualityFlow output for GH-75 [skip ci]

e2b8c8b

QualityFlow added 2 commits June 22, 2026 07:27

Add QualityFlow output for GH-75 [skip ci]

8cd329f

Add QualityFlow STD refinement output for GH-75 [skip ci]

c2a88c9

- Refined STD YAML: removed related_prs from metadata, adjusted assertion priorities - Updated Go stub PSE with expanded Steps context - Added STD review report (APPROVED)

QualityFlow and others added 2 commits June 22, 2026 07:42

Add QualityFlow tests for GH-75 [skip ci]

bad3a04

Clean QualityFlow artifacts for GH-75

e461bf8

Removes intermediate pipeline artifacts (STP, STD, reviews). Test files (1) are co-located in source tree with qf_ prefix. Jira: GH-75 [skip ci]

fullsend-ai-review Bot suggested changes Jun 22, 2026

View reviewed changes

chore: remove old qf-tests/ artifacts

287880a

Co-located tests (qf_* prefix) are now in source package directories. The qf-tests/ directory contained non-compiling tests from the old pipeline.

fullsend-ai-review Bot suggested changes Jun 22, 2026

View reviewed changes

Conversation

guyoron1 commented Jun 21, 2026

Uh oh!

fullsend-ai-review Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Jun 21, 2026

Uh oh!

fullsend-ai-review Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

QualityFlow Pipeline Summary

Test Output

Uh oh!

guyoron1 commented Jun 22, 2026

Uh oh!

fullsend-ai-review Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Jun 22, 2026

Uh oh!

fullsend-ai-review Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Jun 22, 2026

Uh oh!

fullsend-ai-review Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

fullsend-ai-review Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

fullsend-ai-review Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

fullsend-ai-review Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fullsend-ai-review Bot commented Jun 21, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 22, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 22, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 22, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 22, 2026 •

edited

Loading