Open
Conversation
The cmake script previously relied on `gapy` needing to be in the PATH. This makes the cmake script less self-contained and adds a magic ceremonial step required to configure the cmake build. This PR therefore uses cmake's `find_program` to find the `gapy` script instead. This has the following advantages: * We can specify hints where cmake should try and find `gapy`. This way we can add the path from the monorepo layout as a convenient default * If not found through hints, `find_program` will look in `PATH` preserving previous behavior * The `gapy` executable can also be overwritten on the command line using `-DGAPY_SCRIPT_PATH=...` * If not found, a nicer error message is omitted by cmake Additionally, the `gapy` script is now executed using the python interpreter CMake was configured with, not the one that is currently active. This should better ensure that it is always using a venv with the requirements installed if desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cmake script previously relied on
gapyneeding to be in the PATH. This makes the cmake script less self-contained and adds a magic ceremonial step required to configure the cmake build.This PR therefore uses cmake's
find_programto find thegapyscript instead. This has the following advantages:gapy. This way we can add the path from the monorepo layout as a convenient defaultfind_programwill look inPATHpreserving previous behaviorgapyexecutable can also be overwritten on the command line using-DGAPY_SCRIPT_PATH=...Additionally, the
gapyscript is now executed using the python interpreter CMake was configured with, not the one that is currently active. This should better ensure that it is always using a venv with the requirements installed if desired.