fix: Normalize PTY \r\n to \n in captured output#19
Merged
haugoug merged 1 commit intogvsoc:mainfrom Mar 11, 2026
Merged
Conversation
germainh512
force-pushed
the
fix-pty-crlf
branch
7 times, most recently
from
d585dd6 to
81130be
Compare
PTY output capture had race conditions where EIO could fire before buffered data was consumed, causing empty output in Checker commands. Switch to subprocess.PIPE + start_new_session=True: - Pipes give reliable output capture (no EIO races) - start_new_session isolates the process group (prevents terminal corruption from SDL2/ncurses, enables killpg) - stderr merged into stdout via STDOUT - stdin set to DEVNULL 136 tests passing.
germainh512
force-pushed
the
fix-pty-crlf
branch
from
81130be to
3d0ece4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTYs produce
\r\nline endings instead of\n. This causes Checker commands to fail when comparing output against expected strings with\n.Strips
\rfrom each line before storing in test output.