[GW2E-1686] Allow exact component amounts and totalQuantity

[Ecmelt]

No description provided.

[queicherius]

Thanks, could you please also adjust the tests? 🙂 Might just be a case of running yarn test -u

[queicherius]

Fixed the tests, but had an idea - we should calculate the decision price based on the actual amount that needs to be crafted. If I can only craft 10 of an item for 1s each, or buy 1 for 2s each off the TP then the correct choice would be to buy (IMO).

But I believe this would break some display logic around currency prices.

LMK what you think!

[Ecmelt]

Ah was about to add tests here.

Hmm, well it depends on if we assume the items are useless afterwards. As a completionist myself in the past I would ALWAYS go for the bulk because I know I'll use them in future. So I would want gw2efficiency to tell me that. But if you only think about per item then that doesn't make sense.

However, we already show TP price next to items on the tree so user should be able to decide for themselves at that point "do I want to buy this bulk or use the TP price". Maybe add this info into steps instead would be a better approach. "This item is only available in bulk from merchant, also availabe on TP for x price (takes price flag on page for buy or sell order)

[queicherius]

I'd say they are not useless, but they are deep in the tree sometimes, and hard to tell (eg for legendaries).

Maybe add this info into steps instead would be a better approach. "This item is only available in bulk from merchant, also availabe on TP for x price (takes price flag on page for buy or sell order)

I actually really like this idea, I'll add a ticket for it.