Try reduced power proof on CRCError - #11
Merged
Merged
Conversation
Quantum64
commented
Aug 22, 2026
| return proofFile; | ||
| } | ||
| } catch (const CRCError&) { | ||
| break; |
Author
There was a problem hiding this comment.
We exit to the outer for ( ; ; ) loop so that proofSet.reducePower() runs right away. Retrying via the inner loop is hopeless because this kind of error can't be caused by random GPU memory corruption like a verification error might be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof generation can fail in two different ways. If residue corruption happens in memory before CRC generation, then the proof will generate but fail validation. If residue corruption happens any time after CRC generation,
CRCErroris raised before a proof is even generated.CRC errors correctly reduce proof power when loading saved state in
ProofSet::effectivePower, but not in proof generation, where they currently crash the process. We should handle both validation failures and CRC errors during proof generation in the same way via power reduction.