Open
Conversation
obartra
added a commit
to gymnastjs/gymnast
that referenced
this pull request
Apr 10, 2019
Testing updating Storybook 5 with Picturebook 3 - Picturebook 3 supports TS files natively so no need for custom filters, they've been removed - Updated addon usage to remove deprecations following gymnastjs/picturebook#58 - Images changed due to browser images updates but are still correct. The mobile ones now use the appropriate mobile resolution which results in a screenshot more likely to reflect a real use case
Collaborator
Author
|
@arahansen FYI, this should allow for an easy update to storybook 5 without messing with nightwatch or chrome screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes include
yarn add picturebook@alpha) so they can be tested before releasing a stable version 3.0These changes do not include:
Both of these update proved problematic so punting on them for now
For a PR demoing this migration, check gymnastjs/gymnast#408