Repository navigation
fix(node): node 24.22.1 no dev shell e no CI, e o scan de CVE - #86
Merged
Merged
Conversation
h0ffmann
added
tipo/fix
7 tasks
A release de segurança do Node de 2026-10-21 (#83) corrige 10 falhas, 4 altas. O dev shell usava o nodejs do nixpkgs, 24.21.0, afetada; o CI da extensão pegou 22.23.3 de "node-version: 22", também afetada; e o do plugin usava o node do runner, sem versão nos logs. O nixpkgs ainda não tem a 24.22.1. nix/nodejs-bin.nix usa o binário oficial do nodejs.org, fixado pelo sha256 do SHASUMS256.txt da release, cópia do lab do picasso (h0ffmann/picasso#143). Com o patchelf 0.19.2 deste nixpkgs, o autoPatchelf gerava um node que caía no loader; a derivação põe o rpath e depois o interpretador em duas chamadas, não deixa o fixup mexer no ELF e roda node --version no build. O extension.yml e o plugin.yml fixam a 24.22.1. just node-check, no just quality, falha abaixo das versões corrigidas (22.23.4, 24.22.1, 26.12.1) e em qualquer outra linha. O cve.yml roda o OSV-Scanner nos locks deste repositório, o node-check e o is-my-node-vulnerable na main, em cada PR e toda segunda. Refs #83 Tested: nix develop: node v24.22.1, npm 11.19.1; just node-check reprova 24.21.0, 22.23.3 e 20.19.0 e aprova 24.22.1, 22.23.4 e 26.12.1; nix run nixpkgs#osv-scanner num checkout sem submódulos (No issues found); nix run nixpkgs#actionlint; nix develop -c just quality Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
h0ffmann
force-pushed
the
fix/node-24.22.1
branch
from
October 22, 2026 07:40
38c8c37 to
05f5153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo: O Node do dev shell e do CI passa para a 24.22.1, a versão corrigida da release de segurança de 2026-10-21. O nixpkgs ainda não tem essa versão, então o dev shell usa o binário oficial do nodejs.org. Um workflow de CVE passa a rodar na
maindepois de cada merge, em cada PR e toda semana. O shell do site recebe a correção pelo picasso (h0ffmann/picasso#143), num PR seguinte.Testado:
O que mudou
fix(node): onix/nodejs-bin.nixusa o binário oficial da 24.22.1, fixado pelo sha256 doSHASUMS256.txt. Com opatchelf0.19.2 deste nixpkgs, o binário caía no carregador. A derivação aplica o rpath e depois o interpretador, em duas chamadas, e rodanode --versionno build. Oextension.ymle oplugin.ymlfixam a 24.22.1. Ojust node-checkfalha abaixo das versões corrigidas. Ocve.ymlroda o OSV-Scanner nos locks, onode-checke ois-my-node-vulnerable.Refs #83
Summary: The node of the dev shell and CI goes to 24.22.1, the fixed version of the 2026-10-21 security release. nixpkgs does not have that version yet, so the dev shell uses the official nodejs.org binary. A CVE workflow runs on
mainafter each merge, on each PR and every week. The site's shell gets the fix through picasso (h0ffmann/picasso#143), in a later PR.Tested:
What changed
fix(node):nix/nodejs-bin.nixuses the official 24.22.1 binary, pinned by the sha256 ofSHASUMS256.txt. With this nixpkgs'patchelf0.19.2, the binary crashed in the loader. The derivation sets the rpath and then the interpreter, in two calls, and runsnode --versionin the build.extension.ymlandplugin.ymlpin 24.22.1.just node-checkfails below the fixed versions.cve.ymlruns OSV-Scanner over the lock files,node-checkandis-my-node-vulnerable.biprskill