Open Zed in a new window per worktree#643
Merged
Merged
Conversation
Launching Zed via 'open -a Zed <path>' reuses the running window and swaps its project, so opening worktree B replaced worktree A. Special-case Zed in openInApp to invoke the Zed CLI with '-n' (forces a new workspace window), resolving the binary from PATH or the bundled Zed.app/Contents/MacOS/cli, and fall back to 'open -a Zed' when no CLI is found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using Open in → Zed on task A and then on task B swapped the project inside the single running Zed window — worktree B replaced worktree A instead of opening alongside it.
Root cause:
openInApplaunches every editor withopen -a <App> <path>(src/bun/rpc-handlers/app-handlers.ts). For Zed, macOS hands the folder to the already-running instance, which opens it in the current window (Zed's default behavior).Fix
Special-case Zed in
openInApp: invoke the Zed CLI with-n(forces a new workspace window — confirmed in the Zed CLI reference).-nis a Zed-CLI flag thatopen -acan't pass, so we call the CLI directly:/usr/local/bin/zed,~/.local/bin/zed,/opt/homebrew/bin/zed) or the bundledZed.app/Contents/MacOS/cli.open -a Zed <path>if no CLI is found.open -n -a Zedwas rejected — it spawns a whole second app instance (Zed is single-instance), which is not what we want.Scope intentionally limited to Zed; other editors (VS Code, Cursor, IntelliJ, Finder) are unchanged.
Tests
7 new backend tests in
rpc-handlers.test.tscovering: Finder, generic editor, Zed via bundled CLI, PATH-precedence, fallback toopen -a, and path/app-name validation.bun run lintand fullbun run testgreen.Test instructions
/Applications/Zed.app/Contents/MacOS/cliexists (no need to installzedon PATH).open -aas before.🤖 Generated with Claude Code