Skip to content

Fix search field not visibly taking focus when the search window opens #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiMoHo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix search field not visibly taking focus when the search window opens #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions AppController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,17 @@ - (void)windowDidResignKey:(NSNotification *)notification {
[self hideApp];
}

- (void)windowDidBecomeKey:(NSNotification *)notification {
// The search window is opened from a global hotkey while another app is
// active, and app activation is asynchronous on modern macOS. A
// makeFirstResponder: call at show time runs before the window can take
// focus, so the field accepts keystrokes but never shows its caret.
// Focus the field once the window has actually become key.
if ( [notification object] == searchWindow ) {
[searchWindow makeFirstResponder:searchWindowSearchField];
}
}

-(void)fakeKey:(NSNumber*) keyCode withCommandFlag:(BOOL) setFlag
/*" +fakeKey synthesizes keyboard events. "*/
{
Expand Down