Skip to content

Address inconsistency in 99 vs 100 for position. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robf17 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Address inconsistency in 99 vs 100 for position. #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
043dd5c
Address inconsistency in 99 vs 100 for position.
robf17 Jan 4, 2022
4f37af4
Address inconsistency in 99 vs 100 for position.
robf17 Jan 4, 2022
47d827b
Add check on level after set.
robf17 Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions iblindsV3_10.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
* Update Gassgs, Gary G, 10-06-21 - Start Position Change Open/Close commands, Fixed Position Attribute, Fixed update when button pushed
* Update Gassgs, Gary G, 10-11-21 - Added stop command while blind is moving over a duration
* Update Gassgs, Gary G, 11-22-21 - Fixed Battery level attribute update
* Update Rob F, 1-5-22 - Fixed dimmer handler 99/100 limit
* Update Rob F, 1-5-22 - Get level after set to validate change
*
*/
metadata {
Expand Down Expand Up @@ -114,7 +116,7 @@ private dimmerEvents(hubitat.zwave.Command cmd) {
Integer position = cmd.value as Integer
String switchValue = "off"
String windowShadeState = "closed"
if (position > 0 && position < 100) {
if (position > 0 && position < 99) {
switchValue = "on"
windowShadeState = "open"
}
Expand Down Expand Up @@ -189,7 +191,11 @@ def setLevel(value, duration=0) {
}
def setLevel = reverse ? 99 - level : level
def dimmingDuration = duration < 128 ? duration : 128 + Math.round(duration / 60)
zwave.switchMultilevelV2.switchMultilevelSet(value: setLevel, dimmingDuration: dimmingDuration).format()
def delayDuration = ((dimmingDuration + 2 )* 1000)
delayBetween([
zwave.switchMultilevelV2.switchMultilevelSet(value: setLevel, dimmingDuration: dimmingDuration).format(),
zwave.switchMultilevelV1.switchMultilevelGet().format(),
], delayDuration)
}

def endDuration(){
Expand Down