Skip to content

milestone 1#112

Open
Xavier-Royer wants to merge 18 commits into
hack4impact-calpoly:mainfrom
Xavier-Royer:main
Open

milestone 1#112
Xavier-Royer wants to merge 18 commits into
hack4impact-calpoly:mainfrom
Xavier-Royer:main

Conversation

@Xavier-Royer
Copy link
Copy Markdown

Developer: Xavier Royer

Closes # Milestone 1 - Adding Typescript

Pull Request Summary

Added type script to my blog page which uses the blog JSON object to generate html code to auto populate the blog page in a more dynamic and efficient way. Also updated the styling for the blog page to correspond with the new html structure.

Special Instructions (optional)

In my blog.js file the line: Object.defineProperty(exports, "__esModule", { value: true }); auto generates when compiling the typescript file. However, it causes an error when running the website from my file system so I manually comment out the line each time the new js file is compiled. I'm not sure what exactly is going on there.

Pull Request Readiness Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Ask for a review in communication channels

Screenshots/Screencast

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant