milestone 1#112
Open
Xavier-Royer wants to merge 18 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer: Xavier Royer
Closes # Milestone 1 - Adding Typescript
Pull Request Summary
Added type script to my blog page which uses the blog JSON object to generate html code to auto populate the blog page in a more dynamic and efficient way. Also updated the styling for the blog page to correspond with the new html structure.
Special Instructions (optional)
In my blog.js file the line: Object.defineProperty(exports, "__esModule", { value: true }); auto generates when compiling the typescript file. However, it causes an error when running the website from my file system so I manually comment out the line each time the new js file is compiled. I'm not sure what exactly is going on there.
Pull Request Readiness Checklist
Screenshots/Screencast