Skip to content

Milestone 1, 2, 3a, 3b, 4#25

Open
EthanSunjoonYang wants to merge 63 commits into
hack4impact-calpoly:mainfrom
EthanSunjoonYang:main
Open

Milestone 1, 2, 3a, 3b, 4#25
EthanSunjoonYang wants to merge 63 commits into
hack4impact-calpoly:mainfrom
EthanSunjoonYang:main

Conversation

@EthanSunjoonYang
Copy link
Copy Markdown

@EthanSunjoonYang EthanSunjoonYang commented Oct 24, 2024

Developer: Ethan Yang

Closes milestone 4

Pull Request Summary

Submitting milestone 4

Pull Request Readiness Checklist

  • [✅] Code is neat, readable, and works
  • [✅] Comments are appropriate
  • [✅] The commit messages follows our guidelines
  • [✅] The developer name is specified
  • [✅] The summary is completed
  • [✅] Ask for a review in communication channels

Screenshots/Screencast

Screenshot 2025-01-09 at 5 25 53 PM

@EthanSunjoonYang EthanSunjoonYang changed the title Milestone 1 Milestone 1, 2 Dec 19, 2024
@seanmnguyen seanmnguyen self-assigned this Dec 22, 2024
@seanmnguyen
Copy link
Copy Markdown
Collaborator

It looks like you refactored your repo to have separate folders for milestones 1 and 2. This is good, but some of your milestone-1 links no longer work since the file path is now different.

Milestone 2 is looking mostly good! The link to your name "Ethan Yang" in the navbar currently navigates to index.html. Once you make these two small changes your milestones 1 and 2 will be complete, and I'll close this PR. Nice work!

@EthanSunjoonYang EthanSunjoonYang changed the title Milestone 1, 2 Milestone 1, 2, 3a Jan 4, 2025
@EthanSunjoonYang EthanSunjoonYang changed the title Milestone 1, 2, 3a Milestone 1, 2, 3a, 3b Jan 7, 2025
@EthanSunjoonYang EthanSunjoonYang changed the title Milestone 1, 2, 3a, 3b Milestone 1, 2, 3a, 3b, 4 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants