Admin Jobs Request + Nonprofit Renew Button#241
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
markmcguire011
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer: Mark McGuire
Pull Request Summary
Admin Job GET Request: previously, GET requests to the main
/api/jobsroute would yield only 10 jobs (limited for the main job board infinite scrolling), so not all jobs would appear in the admin dashboard. I added a flagisAdminRequestwhich will remove limiting if the request for jobs is coming from the admin page.Nonprofit Renewal Button: nonprofits had no way of renewing expired jobs other than making an edit and returning it to pending, now, clicking the renewal button will automatically send the job to approved.
Admin Renewal Button: implemented the functionality for renewing a job on admin cards, didn't do anything before.
Expired Job Flagging Tweaks: modified expired job flagging logic slightly, tested considerably so everything should work well.
Modifications
(see files changed tab)
Testing Considerations
Test by hard coding a job to be expired (change in mongoDB), then go through the renewal process on both the nonprofit and admin side, also verify that all approved and other categorized jobs appear in their relevant tabs within the admin dashboard.
Pull Request Checklist
Screenshots/Screencast