Skip to content

Styling + Cleanup + Other Changes#249

Merged
noahgiboney merged 9 commits into
developfrom
duplicates
Jun 3, 2025
Merged

Styling + Cleanup + Other Changes#249
noahgiboney merged 9 commits into
developfrom
duplicates

Conversation

@markmcguire011
Copy link
Copy Markdown
Collaborator

Developer: Mark McGuire

Pull Request Summary

  • Cleanups: removed unnecessary imports from files and duplicate or unnecessary files.
  • Dashboard Page No Job Message: updated the message displayed when a nonprofit hasn't submitted any jobs to retain more of the base layout and provide more of an informative message.
  • Fixed Admin Autofill Override: implemented a fix to check if a job is being edited, and if so to not populate the fields with the admins information and organization name to prevent unwanted overrides.
  • Edit Page Styling: updated the styling for the update/reject/delete buttons on the edit page for individual jobs to be less visually jarring.
  • Action Button Component: created component for the approve/reject/renew action buttons for the admin card just to standardize styling and improve reusability.
  • Job Modal Loading State Standardization: made sure all modals when opened on either the buttons on the admin cards or the edit page have the same loading states. This prevents users from accidentally clicking the modal confirm button multiple times and sending multiple API requests and receiving multiple toasts.

Modifications

(see files changed tab)

Testing Considerations

I tested the full new job --> reject --> update --> approve --> manually set to expire flow and everything worked well when using the admin card buttons and the buttons on the edit page.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Updated Button Styling
Screenshot 2025-06-03 at 11 51 14 AM

New No Jobs Message
Screenshot 2025-06-03 at 12 06 28 PM

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spokes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 7:49pm

Copy link
Copy Markdown
Collaborator

@noahgiboney noahgiboney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That empty state for the non profits is fire

@noahgiboney noahgiboney merged commit d878dc2 into develop Jun 3, 2025
6 checks passed
@noahgiboney noahgiboney deleted the duplicates branch June 3, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants