Skip to content

Refresh Button + Other Changes#251

Merged
noahgiboney merged 6 commits into
developfrom
form-testing
Jun 4, 2025
Merged

Refresh Button + Other Changes#251
noahgiboney merged 6 commits into
developfrom
form-testing

Conversation

@markmcguire011
Copy link
Copy Markdown
Collaborator

Developer: Mark McGuire

Pull Request Summary

  • Refresh Button: I found some cases where approvals/rejections/renewals weren't reflected in the admin dashboard until the page was refreshed so I just added a button to handle refetching the data. Not the most ideal fix but it works and we don't have much time.
  • Loading State for Edit Page Button Card: added a loading state for the update/reject/delete buttons on the jobform edit page to prevent updates/rejections that get sent to the endpoint with no data loaded and inadvertently wipe the job.
  • Job Filtering: Once an action is taken on a job, it is filtered out of the category it was previously in the state (I think this was implemented before and I accidentally removed it).

Modifications

(see files changed)

Testing Considerations

Tested full flow and trying to refresh right after an approval/rejection and everything works accordingly.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Loading State
Screenshot 2025-06-03 at 8 44 32 PM

Refresh Button
Screenshot 2025-06-03 at 8 44 23 PM
Screenshot 2025-06-03 at 8 44 13 PM

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spokes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 3:52am

Copy link
Copy Markdown
Collaborator

@noahgiboney noahgiboney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates

@noahgiboney noahgiboney merged commit 8098c4a into develop Jun 4, 2025
6 checks passed
@noahgiboney noahgiboney deleted the form-testing branch June 4, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants