Skip to content

Frog Says NFC Tag#38

Open
j0lynN-Y wants to merge 9 commits into
hackclub:mainfrom
j0lynN-Y:main
Open

Frog Says NFC Tag#38
j0lynN-Y wants to merge 9 commits into
hackclub:mainfrom
j0lynN-Y:main

Conversation

@j0lynN-Y

Copy link
Copy Markdown

No description provided.

@qcoral

qcoral commented Jan 27, 2025

Copy link
Copy Markdown
Member

hey!! awesome job on this - could you update your submission to follow the formatting of the example? Link here:

https://github.com/hackclub/asylum/tree/main/designs/nfc_keytags/hack_club_keytag

specifically add a README.md with a picture of your keytag. Thanks!!! will review soon

@souptik-samanta

Copy link
Copy Markdown
Contributor

the cavity for the nfc tag is not present
check this out
https://github.com/hackclub/asylum/blob/main/designs/nfc_keytags/README.md

@github-actions

Copy link
Copy Markdown

Hey!! awesome job on this asylum submission. Can't wait to you build it.%0A%0AThis is just a friendly reminder to make sure your PR follows the example format, including directory structure:%0A%0A- For weather stations: Example here%0A- For NFC tags: Example here%0A%0AThe most important part is that you have a README.md file documenting your design. Make sure there are images of your design in it! Otherwise it will not be accepted.%0A%0AThis is an automated message, so you can ignore it if you have everything already! %0A%0ASend a message in #asylum once you've made the changes - you'll get your PR reviewed faster

@github-actions

Copy link
Copy Markdown

Hey!! awesome job on this asylum submission. Can't wait to see you build it.

This is just a friendly reminder to make sure your PR follows the example format, including directory structure:

The most important part is that you have a README.md file documenting your design. Make sure there are images of your design in it! Otherwise it will not be accepted.

This is an automated message, so you can ignore it if you have everything already!

Send a message in #asylum once you've made the changes - you'll get your PR reviewed faster

@piplup7575

Copy link
Copy Markdown
Member

Can you add an image to your readme.md?
Cavity is also not properly present, it is still filled in (see below)

@jo
id U078SNVHSRK

image

filled in cavity
image

@qcoral qcoral left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants