Add my weather station#53
Open
Jaisinh wants to merge 6 commits into
Open
Conversation
Contributor
Author
qcoral
requested changes
Feb 26, 2025
qcoral
left a comment
qcoral
left a comment
Member
There was a problem hiding this comment.
awesome job on this weather station! couple things:
- great start on the README! Could you add a bit more about what it does?
- could I get a BOM for everything? btw - you don't need pullups on the buttons, because the ESP32 has them built in!
Contributor
Author
|
@qcoral I have made the necessary changes. I had asked an onboard reviewer before, and they mentioned that a resistor might be needed. If you think it isn't necessary, I will connect the pads with a wire |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the previous pr: #50
Changes suggested/made: