Repository navigation
fix(editor): update closed pull requests and harden branch creation - #4376
Merged
LucasHT22 merged 8 commits intoOct 15, 2026
Merged
Conversation
|
@SSoggyTacoMan is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
SSoggyTacoMan
marked this pull request as ready for review
October 13, 2026 08:51
…sed PR metadata updates
LucasHT22
requested changes
Oct 13, 2026
LucasHT22
left a comment
Member
There was a problem hiding this comment.
edge case: the closed-PR search silently ignores API errors and returns null, so the publish flow can create a new PR even when it couldn't confirm that an existing one doesn't exist
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
(this is about that edge case in #sprig channel you dmed about) |
LucasHT22
approved these changes
Oct 15, 2026
LucasHT22
left a comment
Member
There was a problem hiding this comment.
it does works but a review is worth it, i'm gonna merge for now but let's keep an eye on this
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an author's pull request is closed (e.g. by a maintainer or bot triage) and they click Publish The Game again to push revisions:
findGamePullRequestignored closed PRs, forcing a new branch/PR creation flow.createBranchsent JSON withoutContent-Type: application/jsonheader, threw 404, or hit unprovisioned fork timing.Changes
findGamePullRequest.Content-Typeheader increateBranch,createCommit, andcreatePullRequest.main./userrather than/.