Repository navigation
fix(ci): clarify image triage checks and prevent bad filename cascading - #4383
Merged
LucasHT22 merged 7 commits intoOct 15, 2026
Merged
Conversation
|
@SSoggyTacoMan is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
SSoggyTacoMan
marked this pull request as ready for review
October 14, 2026 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In PRs like #4344:
games/img/, strict regex matching causes them to be treated as disallowed folder violations (Files stay in allowed folders), giving confusing errors for files that are ingames/img/.Fix
submission-manifest.mjs, allow all files undergames/img/intoimageFilesLooseso image-specific checks handle them rather than failing the general folder check.allImageFilesso misplaced images (e.g.screenshots/foo.png) triggerOptional image path(Move images into games/img/...) alongside folder checks.At most one image filecheck explaining that only one image is allowed as the gallery thumbnail, listing the files and advising deletion of extra images.validateImageFiles, if the game filename contains spaces or invalid characters, provide a clear unified rename recommendation (e.g.games/Retro_space_shooter.jsandgames/img/Retro_space_shooter.png).dr._mario.js.encodeURIComponentto ensure filenames containing spaces,#, or?don't break markdown link formatting..github/scripts/submission-manifest.test.mjs.