Skip to content

Fix gallery play page layout overflow and show action buttons for guests - #4401

Open
SSoggyTacoMan wants to merge 5 commits into
hackclub:mainfrom
SSoggyTacoMan:fix/gallery-play-page
Open

SSoggyTacoMan wants to merge 5 commits into
hackclub:mainfrom
SSoggyTacoMan:fix/gallery-play-page

Conversation

@SSoggyTacoMan

Copy link
Copy Markdown
Contributor

Supersedes #4076. Fixes #3467.

Summary of changes

  1. Fix player layout overflow on smaller displays (e.g. 1366x768):

    • In desktop-player.module.css, replaced position: fixed with responsive flex container sizing.
    • Constrained canvas scaling with max-height: min(800px, calc(100vh - 250px)) in embedded mode and width: auto, maintaining aspect ratio while ensuring the canvas and controls fit comfortably within the viewport.
    • Removed position: absolute on .screenControls so controls naturally position directly below the canvas and match its width.
    • Added native :fullscreen styles so fullscreen scaling works reliably when requested.
    • Added an embedded prop to DesktopPlayer to cleanly skip rendering the unused metadata sidebar (#desktop-player-meta).
  2. Show action buttons for logged-out visitors:

    • In MainNavbar, rendered props.children in the logged-out branch instead of dropping custom actions, allowing guests to use "View Code" and "Remix Game".

@vercel

vercel Bot commented Oct 16, 2026

Copy link
Copy Markdown

@SSoggyTacoMan is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Game Play page is broken and not functional

2 participants