Repository navigation
fix(ci): preserve review states across empty and merge commits without game changes - #4402
Merged
LucasHT22 merged 5 commits intoOct 20, 2026
Conversation
|
@SSoggyTacoMan is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
LucasHT22
approved these changes
Oct 18, 2026
LucasHT22
left a comment
Member
There was a problem hiding this comment.
There’s an edge case with cherry picked commits but lgtm for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a maintainer updates a PR branch with
mainor an empty commit is pushed without touching submission game files:review-state.mjs,CHANGES_REQUESTEDandAPPROVEDstrictly matchedr.commit_id === headSha. A merge commit changedheadSha, which falsely clearedCHANGES_REQUESTEDback toReady for Playtest(as seen on [Sprig App] Galaxy shooter #4046) or demoted anAPPROVEDPR back toReady for Playtest.stale-review-queue.mjs, author commits did not count towards author activity (only issue comments did), andhandleUntouchedSubmissionusedpullRequest.updated_at(which maintainer branch updates refreshed).Changes
isReviewCommitOutdatedinreview-utils.mjscomparing the diff betweenreview.commit_idandheadShafor submission files ingames/.reconcileReviewStatusinreview-state.mjsto accept an outdated check, preservingchanges_requestedandapprovedstates across commits that do not touch game files.auto-triage.mjsandsync-reviews.mjsintoisReviewCommitOutdated.stale-review-queue.mjsto count author commits toward activity and ignore automated/maintainer updates when computing untouched submission age.isReviewCommitOutdatedcompare diff checking.