Closed
Conversation
…y chats - Replace setChatMode(mode) with selectAskMode() / selectAgentMode(); enforce free subscription and temporary-chats constraints inside selectAgentMode(); expose effectiveChatMode for model persistence. - Make temporary chats URL source of truth via useSearchParams(); replace setTemporaryChatsEnabled(bool) with enableTemporaryChats() / disableTemporaryChats() that update query via Next router. - Remove redundant typeof window checks in URL-sync effects. - Update ChatHeader, ChatInput, ChatModeSelector, ModeSelectorContent, SidebarHeader, and chat.tsx to use new APIs; remove ChatInput useEffects that forced ask mode (logic lives in GlobalState). Made-with: Cursor
… state
- Derive chatId and isExistingChat from route (routeChatId); remove
local chatId/isExistingChat state and URL sync effect. Use stable
local ref for new-chat id when route has no id.
- On new-chat reset call router.replace("/"); update URL to /c/[id]
in send handler when sending first message (not in onFinish).
- Clear message queue in selectAskMode and on chatId change (cleanup);
remove separate clear-when-switching-to-Ask effect.
- Require chatId === routeChatId for isChatNotFound to avoid flash
during new-chat transition; simplify sandbox init and hasSavedSandboxType.
Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR refactors the GlobalState API to replace generic setter functions with specific action functions ( Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit