Skip to content

Enable passkey authentication#146

Merged
malkoG merged 1 commit intohackers-pub:mainfrom
malkoG:feature/enable-passkey-auth
Apr 25, 2026
Merged

Enable passkey authentication#146
malkoG merged 1 commit intohackers-pub:mainfrom
malkoG:feature/enable-passkey-auth

Conversation

@malkoG
Copy link
Copy Markdown
Collaborator

@malkoG malkoG commented Apr 25, 2026

Summary

Enable the passkey authentication feature flag so passkey support is active in the Android client. On Android 9 and newer, this exposes passkey sign-in on the username step and the passkeys management section in Settings; older devices continue using the existing email verification flow.

Why

  • Make the shipped passkey flow available behind the existing platform gate.
  • Keep behavior unchanged on devices that do not support the Credentials API requirement.

Before and After

Before After
Passkey auth stayed hidden because PASSKEY_AUTH_ENABLED was false. Passkey auth is enabled on Android 9+ where the UI already gates support.
Settings did not expose passkey management. Settings shows passkey listing, add, and revoke actions on supported devices.

Commit History

  • d20dd0a Enable passkey authentication: Turn on the passkey feature flag and expose the existing passkey sign-in and settings management flows on supported Android versions.

Test Plan

  • Run ./gradlew :app:lintDebug
  • On an Android 9+ device or emulator, confirm the username sign-in screen shows the passkey action.
  • On an Android 9+ device or emulator, confirm Settings shows passkey management and existing add/remove flows still work.
  • On an Android 8.1 or lower device or emulator, confirm the app still uses the email verification flow without passkey UI.

Assisted-By: Codex(gpt-5)

Turn on the passkey auth feature flag so Android 9+ devices show the passkey sign-in action on the username screen. This also enables the passkeys section in Settings for listing, adding, and revoking passkeys, while older devices keep the existing email verification flow.

Co-authored-by: Codex <noreply@openai.com>
Assisted-By: Codex(gpt-5)
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 25, 2026

Warning

Rate limit exceeded

@malkoG has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 34 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 25 minutes and 34 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42002522-b117-41ba-92b3-51afe8a5ca1e

📥 Commits

Reviewing files that changed from the base of the PR and between 4126f5f and d20dd0a.

📒 Files selected for processing (1)
  • app/src/main/java/pub/hackers/android/FeatureFlags.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@malkoG malkoG merged commit bd299f6 into hackers-pub:main Apr 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant