SWE-agent[bot] PR to fix: Incorrect namings of CAST_TYPE instructions in PyEval.eval#13
Draft
github-actions[bot] wants to merge 10 commits into
Draft
SWE-agent[bot] PR to fix: Incorrect namings of CAST_TYPE instructions in PyEval.eval#13github-actions[bot] wants to merge 10 commits into
github-actions[bot] wants to merge 10 commits into
Conversation
7d0c0f9 to
ebbb14d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR opened by AI tool SWE Agent to close #4 (Incorrect namings of CAST_TYPE instructions in PyEval.eval).
Closes #4.
Thought process ('trajectory') of SWE-agent (click to expand)
🧑🚒 Response (0):
👀 Observation (0):
🧑🚒 Response (1):
👀 Observation (1):
🧑🚒 Response (2):
👀 Observation (2):
🧑🚒 Response (3):
👀 Observation (3):
🧑🚒 Response (4):
👀 Observation (4):
🧑🚒 Response (5):
👀 Observation (5):
🧑🚒 Response (6):
👀 Observation (6):
🧑🚒 Response (7):
👀 Observation (7):
🧑🚒 Response (8):
👀 Observation (8):
🧑🚒 Response (9):
👀 Observation (9):
🧑🚒 Response (10):
👀 Observation (10):
🧑🚒 Response (11):
👀 Observation (11):
🧑🚒 Response (12):
👀 Observation (12):
🧑🚒 Response (13):
👀 Observation (13):
🧑🚒 Response (14):
I dug into
quark/evaluator/pyeval.pyand found the CAST_TYPE opcodes were registered as{type1}-{type2}, which mismatches Dalvik’s{type1}-to-{type2}naming. I added a quick repro script that checks for the expected*-to-*keys and verified it failed initially.Changes made:
{first_type}-to-{second_type}.CAST_TYPEparsing to split on-to-(with a fallback to the old format for robustness).Repro script (
repro_cast_issue.py) now passes:This aligns Quark with the Dalvik naming convention and matches Androguard/shuriken formats, so those cast instructions will no longer be skipped.
👀 Observation (14):
🧑🚒 Response (15):
👀 Observation (15):
🧑🚒 Response (16):
👀 Observation (16):
🧑🚒 Response (17):
👀 Observation (17):