Fix template rendering: always render directives and cache git diff#13
Merged
hahwul merged 2 commits intoMay 27, 2026
Conversation
- util.cr: Always call TemplateRenderer.render even when vars is nil,
so {{.File}} and {{.GitDiff}} work without --var
- retry.cr: Same fix for retry command's template rendering
- template_renderer.cr: Compute git diff once per render call and reuse
via string replace instead of calling get_git_diff per regex match
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix template rendering: always render directives and cache git diff
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template directives (
{{.File}},{{.GitDiff}}) were only rendered when--varwas passed, because rendering was gated onvarsbeing non-nil. Additionally, multiple{{.GitDiff}}occurrences triggered redundantgit diffsubprocess calls.util.cr:PromptInput.resolvenow always callsTemplateRenderer.render, passing an empty hash when no vars are providedretry.cr: Same fix — rendering no longer conditional onvarspresencetemplate_renderer.cr: Computegit diffonce per render call and reuse viaString#gsubinstead of invokingget_git_diffper regex match