Skip to content

Fixed broken tests and cleanup#26

Merged
halbornteam merged 4 commits into
mainfrom
fix/tests
May 12, 2025
Merged

Fixed broken tests and cleanup#26
halbornteam merged 4 commits into
mainfrom
fix/tests

Conversation

@halbornteam
Copy link
Copy Markdown
Owner

@halbornteam halbornteam commented Nov 4, 2024

Problem:
Tests did not work due to breaking changes in dependencies.
Running tests as cargo test --features anchor --features pyth return multiple compilation errors.

Solution:

  • Cargo.lock removed from .gitignore (previous recommendation to not check in Cargo.lock for libraries has changed)
  • Deploy non-upgradable program is no longer supported (Feature Gate: Disable bpf loader management instructions solana-labs/solana#34424) - deploy_program function was kept for backwards compatibility but now uses upgradable loader)
  • Fixed outdated processor macro. Also now it is possible to use this macro with new anchor entrypoint function.
  • Updated structure of the new Pyth Oracle price account.
  • Replaced various deprecated functions and structs with new equivalents.
  • Fixed compiler warnings.
  • Bumped dependencies versions.
  • Fixed create_associated_token_account to work with spl_token_2022::ID as suggested in PR#23.
  • Fixed add_empty_account_with_anchor to work with future Anchor versions:
    lang: Remove discriminator method from Discriminator trait otter-sec/anchor#3163 as suggested in PR#23.

@Ikrk Ikrk changed the base branch from solana1.18 to main November 4, 2024 14:57
@halbornteam halbornteam requested a review from IsabelBL0 November 5, 2024 13:30
@halbornteam halbornteam marked this pull request as ready for review November 5, 2024 13:30
Ikrk added 4 commits May 6, 2025 16:10
- Cargo.lock removed from .gitignore (previous recommendation to not check in Cargo.lock for libraries has changed)
- Deploy non-upgradable program is no longer supported (solana-labs/solana#34424) - deploy_program function was kept for backwards compatibility but now uses upgradable loader)
- Fixed outdate processor macro. Also now it is possible to use this macro with new anchor entrypoint function.
- Updated structure of the new Pyth Oracle price account.
- Replaced various deprecated functions and structs with new equivalents.
- Fixed most of the compiler warnings.
- Bumped dependencies versions.
- Fixed create_associated_token_account to work with spl_token_2022::ID as suggested in [PR#23](#23).
- Fixed add_empty_account_with_anchor to work with future Anchor versions:
otter-sec/anchor#3163  as suggested in [PR#23](#23).
@halbornteam halbornteam merged commit baa770f into main May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants