Skip to content

Conversation

@dontcallmedom
Copy link
Contributor

No description provided.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't related to the current pull request - which is fine with me. But I am curious about what problem you were solving with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually is related; I want to allow to specify "#foo" as valid fragment check to suppress (since when you do that from a file, you don't want to hardcode the path of the file you're checking).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh - nice feature. I see how it works. Maybe we should document that if a line in the file is only a fragment it is appended to the base URI being checked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that'd make sense; can you suggest something that would fit in a command line help?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you may specify a fragment with no scheme or path (e.g., #myfragment). In this case the fragment will be considered internal to the URI being checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants