support reusing the same zstd encoder/decoder. #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
if we support closing the zstd encoder/decoder as in other PR, it will have to be addressed here to not close it if using an outside encoder/decoder |
Contributor
Author
|
@nrwiersma you think you will have time to go over it? its a small PR. |
Member
|
In the new year only. I am away at the moment. |
Contributor
Author
|
ok, thank you enjoy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a use case where i have ~1000 different encoders writing each to a different file.
i want to limit the overall concurrency of the underlying zstd encoder.
in order to achieve this i can use a shared zstd encoder across all avro writers/encoders.