fix: ゲーム開始時にタイマーとOBS録画が開始しない問題を修正 (v1.0.1) - #2
Merged
Conversation
active_process_name 未設定のゲーム(大多数)で GameProcessWatcher.tick() の on_active() が永久に呼ばれず、プレイ時間カウントとOBS自動録画が機能しなかった。 v0.8 の active_process_name 配線修正により active_process_names が空集合になり、 is_active が常に False → on_game_active() に到達不能になっていた回帰バグ。 修正: is_running の初回検知時に active_process_names が空なら on_active() を発火。 tests/test_start_watcher.py に ProcessWatcherOnActiveTest(5件)を追加。 132 件全通過。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ゲームを起動してもプレイ時間のカウントが開始しない・OBS録画が開始しないという問題を修正します(v1.0.1)。
active_process_nameを設定していないゲーム(大多数)が影響を受けます。原因
v0.8 の
active_process_name配線修正が回帰バグを導入。active_process_nameが空のゲームではGameProcessWatcher.tick()のon_active()が永久に呼ばれず、on_game_active()に到達できないためタイマーも OBS 録画も開始しない。修正
playcue/tracking/process_tracker.pyのtick()に1分岐を追加:active_process_name未設定かつprocess_nameが初回検知されたとき →on_active()を発火。テスト
132 件全通過(
ProcessWatcherOnActiveTest5件を新規追加)🤖 Generated with Claude Code