feat: remove args node type and clean up related resources - #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed the deprecated
argsnode type from the Obsidian Canvas workflow execution plugin "Runestone".Warning
This release deprecates and completely removes the
argsnode type (runestone.type: args).Workflows containing
argsnodes will fail pre-execution validation. Please refer toMIGRATION.mdfor steps on migrating your workflows to script-based parameter nodes or inline variables.Note: For backward compatibility, the executor still injects an empty object
{}for theargsparameter in scripts/templates to avoid immediate runtime ReferenceErrors.Motivation
With the introduction of the explicit
startnode marker, the entry points of workflows are now clearly defined. As a result, theargsnode—which was originally introduced to avoid ambiguity when multiple entry nodes existed—is no longer necessary and has been deprecated.Key Changes
"args"fromRunestoneNodeType.args-specific graph validation rules (such as block requirements and edge constraints) and parsing logic.anyArgsEdgeDismissedchecking, and warning logs for theargsnode from the execution engine.argsvariables or templating like{{args.key}}, the executor still injects an empty object{}for theargsparameter, avoiding runtime errors likeReferenceError.args-specific test cases and updatedmakeNodehelpers inexecutor.test.tsandvalidator.test.ts.argsnode fromAGENTS.md,REQUIREMENTS.md,GLOSSARY.md, andREADME.md.argsnode deprecation inMIGRATION.md(v0.4 section).argsnode references in Claude Code skill definition (SKILL.md) and removedargs-node.mdtemplates.vault.example) by deleting theargs-exec-exampleand refactoringpara-noteworkflow to pass parameters using the upstream config node via theinputarray rather than the deprecatedargsnode.Verification Results
npm run lintcompletes with no errors or warnings.