fix: support multiple concurrent MCP client connections#295
Open
dddabtc wants to merge 1 commit intohangwin:masterfrom
Open
fix: support multiple concurrent MCP client connections#295dddabtc wants to merge 1 commit intohangwin:masterfrom
dddabtc wants to merge 1 commit intohangwin:masterfrom
Conversation
…urrent connections The MCP Server (Protocol) instance was a singleton shared across all sessions. When a second client sent an initialize request, Protocol.connect() threw "Already connected to a transport" because the singleton was already bound to the first client's transport. Replace the singleton getMcpServer() with a factory createMcpServer() so each new transport gets its own MCP Server instance, allowing multiple clients to connect simultaneously via both /mcp and /sse endpoints.
|
@dddabtc, your solution is good and works great! I've checked. However, today @PyEL666 proposed a more elegant solution #301 that is backward-compatible which seems cleaner:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server(Protocol) instance was a singleton shared across all sessions. When a second client sent aninitializerequest to/mcp,Protocol.connect()threw"Already connected to a transport"because the singleton was already bound to the first client's transport.getMcpServer()with a factory functioncreateMcpServer(), so each new transport (both/mcpStreamableHTTP and/sseSSE) gets its own independent MCP Server instance.Steps to reproduce (before fix)
Changes
app/native-server/src/mcp/mcp-server.tsgetMcpServer()with factorycreateMcpServer()app/native-server/src/server/index.tscreateMcpServer()for each new transport in/mcpand/sseendpointsTest plan
mcp-session-idheader → still works/ssewith multiple clients → works independently