Open
Conversation
Signed-off-by: Alexander Ivanov <oshli.a.er@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses MCP Streamable HTTP session cleanup for the stdio MCP server by tracking the client transport session ID and terminating it when the stdio process exits.
Changes:
- Persist the Streamable HTTP client
sessionIdafter connecting so it can be cleaned up later. - Add an async shutdown routine that issues an HTTP
DELETE /mcpwithMcp-Session-Idbefore closing the MCP client/server and exiting. - Add exit detection via stdin end/close handlers plus a parent-PID watchdog timer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove redundant non-null assertion (sessionId!) - Add isCleaningUp flag to prevent concurrent cleanup calls - Add AbortController with 3s timeout for DELETE request - Check ESRCH error code in parent PID watchdog Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
oshliaer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered an issue when switching between MCP clients in stdio mode. After several connect/disconnect cycles, all sessions became occupied and new clients could not connect.
Changes:
This ensures sessions are properly released on the server when stdio client terminates.