refactor: change methods not using its bound instance to staticmethods#3
Open
deepsource-autofix[bot] wants to merge 1 commit into
Open
refactor: change methods not using its bound instance to staticmethods#3deepsource-autofix[bot] wants to merge 1 commit into
deepsource-autofix[bot] wants to merge 1 commit into
Conversation
The method doesn't use its bound instance. Decorate this method with `@staticmethod` decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation. Read more about staticmethods [here](https://docs.python.org/3/library/functions.html#staticmethod).
Reviewer's Guide by SourceryThis pull request refactors methods that do not use their bound instance by decorating them with the @staticmethod decorator. This change improves memory and computational efficiency by preventing Python from instantiating a bound method for each class instance. Class diagram showing staticmethod changes in classifier and generatorclassDiagram
class Classifier {
-model
+_split_data(path: Path)
+show_score()
+_tokenize()$
+train()$
+test()$
+predict()$
}
note for Classifier "Methods marked with $ are now static"
class Generator {
-model
-tokenizer
+__init__(config: dict, format: Callable)
+_openai_generate(input: str, base_url: str, model_name: str, api_key: str)$
}
note for Generator "Methods marked with $ are now static"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method doesn't use its bound instance. Decorate this method with
@staticmethoddecorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation. Read more about staticmethods here.Summary by Sourcery
Enhancements: