Conversation
HLS streams were using VOD cache settings (cache-secs=300, demuxer-max-bytes=512MiB), forcing mpv to pre-download 5 minutes of segments before playback. Add HLS detection via .m3u8 URL check and apply HLS-appropriate settings: cache-secs=10, demuxer-max-bytes=16MiB, demuxer-readahead-secs=5. Fixes harborstremio#1303
When applying a picture adjustment preset, all PICTURE_KEYS are now reset to defaults before the preset values are applied, instead of merging presets on top of current slider values. Fixes issue where presets were cumulative — e.g. applying "Punchier color" after "Brighten dark movies" would retain the gamma/brightness changes instead of replacing them.
|
@harborstremio just wanted to check if you could take a look at this PR and merge it if it works, since it may resolve the issue I reported in #1303. I saw you’ve been releasing betas over the past couple of days so i thought I'd ask. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix HLS streams taking minutes to start or failing entirely. HLS URLs were getting VOD cache settings (5 min/512MB pre-download) instead of lightweight HLS-appropriate settings.
Changes
src-tauri/src/mpv.rs: Detect .m3u8 URLs and apply HLS cache settings (cache-secs=10, demuxer-max-bytes=16MiB)src/lib/streams/parser/parser-cache-flags.ts: HLS cache flag detectionVerification
Closes #1303