fix(player): load mpv scripts before init; place separate-window player on Harbor's display - #1422
Closed
Thunderhawkk wants to merge 1 commit into
Closed
Thunderhawkk wants to merge 1 commit into
Thunderhawkk wants to merge 1 commit into
Conversation
…er on Harbor's display
Collaborator
|
Release tracking: this work was integrated through our experimental/beta release branch and is carried in Beta 0.9.126 (published build e758926), with integration adjustments where needed. Closing the PR as already incorporated into the release build; this does not indicate a new merge into the upstream beta branch. Thank you for the contribution. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows HDR script loading and separate-window display placement:
Script loading: scripts, script-opts, and load-scripts are init-only mpv options that cannot be set after mpv_initialize. extra_options are now split into init-only and runtime pairs so scripts (e.g. hdr-mode.lua, display-info.lua) are applied before initialization.
Separate-window placement: the separate-window player always opened on the primary monitor. It now opens on the monitor where the Harbor main window sits, by resolving the main window's monitor index and setting mpv's screen option before init.
Removed dead vo-window tracking: drops MPV_VO_MONITOR / capture_mpv_vo_monitor — the vo window is destroyed before restore runs, so the feature could never work. SDR restore now simply targets the Harbor main window's monitor.
Known limitation (intentional, not addressed here): separate-window mode still does not flip the display back to SDR on exit. That behavior is left as-is per the current scope; only embedded-mode exit restore is guaranteed.
Why
Verification
Platform Impact
Checklist
vp checkfor the changed files.vp run typecheckafter TypeScript changes.