Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change adds candidate path hints to file opening. Transcript tool paths are collected and forwarded to workspace-aware resolution, which uses unambiguous referenced paths when indexed project lookup cannot resolve a short link. ChangesTranscript File Resolution
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant AgentTranscript
participant App
participant resolveOpenablePath
AgentTranscript->>App: Pass requested path and candidatePaths
App->>resolveOpenablePath: Resolve path against cwd and candidates
resolveOpenablePath-->>App: Return referenced or fallback path
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The transcript file-link resolution update preserves existing indexed-file behavior and avoids guessing among ambiguous transcript paths. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks @yankawai the intent makes sense but I noticed two issues before merging:
One smaller follow-up, right-click actions such as “Open in Default App” and “Reveal” bypass The overall approach looks good once these cases are addressed. |
Pull request
Title: Resolve shortened transcript file paths
What changed
Shortened file links in a transcript now carry exact paths previously surfaced by structured tool events into the file resolver. Indexed files in the current project still take precedence, and ambiguous transcript matches are left unresolved instead of guessing.
Why
When a session starts in one directory but an agent edits a file in another project, a later
backup.yamlchip was resolved as<session cwd>/backup.yaml. The editor then showed an ENOENT error even though the transcript already contained the exact tool path.With this change, a unique exact tool path is used as the fallback. Direct file links, navigation locations, project-index matches, and tool-preview clicks keep their existing behavior.
UI
No layout change.
Before: a shortened chip could open a nonexistent path under the session cwd.
After: the chip opens the unique matching path already recorded by the transcript.
Checklist
npm run check(1,781 web tests and 236 Rust tests)Summary by CodeRabbit
New Features
Bug Fixes
Tests