Update TaskbarIcon.Declarations.cs#60
Open
Tetley22 wants to merge 2 commits intohardcodet:developfrom
Open
Conversation
Long-overdue contributor recognition.
Added support for dynamic, in-memory icons to be assigned at the xaml level. This allows better support for MVVM design.
Collaborator
|
Thank you for sharing this PR, sorry for the delay but I have a lot of my plate. I see a bit of an issue with this change, an Icon is a IDisposable, so it needs to be disposed otherwise a memory leak will happen. The OnIconInMemoryPropertyChanged will overwrite it, and not allow it to be disposed. The issue is that sometimes an icon needs to be disposed and sometimes not (as you will need it), and for these scenarios we might want to have a better solution. I know there were some other issues with icons, I need to consolidate all of that to come up with one... bear with me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for dynamic, in-memory icons to be assigned at the xaml level. This allows better support for MVVM design.
For a small wpf project I created, I wanted the ability to generate icons at runtime, while maintaining MVVM design pattern. The only way I could figure out how to assign dynamic in-memory icons was to break MVVM and access the TaskbarIcon object directly in the ViewModel code. So I added this ability which worked well for my needs, and thought I'd share if you are interested in it.
Usage in xaml:
In ViewModel (where TrayIcon is set via dynamic icon generation):
public Icon TrayIcon
{
get
{
return _trayIcon;
}
set
{
_trayIcon = value;
NotifyPropertyChanged(nameof(TrayIcon));
}
}