chore(deps): take the js-yaml denial of service out of the toolchain - #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm audit --audit-level=highreported two high-severity findings — this time a real advisory, not the unreachable service of #80:Published after the last green run: nothing in the repository changed. It surfaced on #93, which touches no dependency at all.
What it is worth, said plainly
A development dependency only.
openapi-typescriptgenerates the frontend's types from our ownopenapi.jsonand never reaches a merchant's installation. The attack is a denial of service through crafted YAML, and the only YAML this toolchain reads is the contract this repository produces.Fixed anyway, and quickly, because a gate that stays red teaches everyone to ignore it — which costs more than the advisory ever could.
Blast radius, measured
package-lock.jsononly.package.jsonis untouched, so no declared range moves.npm audit --audit-level=highreports 0 vulnerabilities afterwards.The one thing worth watching
The update touches the tool that generates our API types. If generation changed by a character,
just api-checkwould say so:It does not. The same contract produces the same file.
Test plan
just frontend-check— typecheck, lint, theme tokens, type scalejust frontend-test— 190 tests in 24 filesjust frontend-build— gallery still absent from the built assetsjust api-check— generated types unchangednpm audit --audit-level=high— 0 vulnerabilitiesBackend untouched, so
backend-check,backend-testandcargo auditdo not apply. No source file changed, sojust e2ehas nothing new to exercise — the frontend build and the type check are what a lockfile bump can break, and both are green.Closes #94