fix(intake): name the missing recordings in the same refusal - #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkCapturesbuilt the missing-content list from the captures alone: a client pushing captures and videos got two 409s instead of one (name the missing recordings in the same refusal as the captures #223, reproduced against a local server)missing-contentanswer — existence checked only, never their format (ADR 0013)Blobsport gainsExists, already carried by the file storeTest plan
TestAMissingRecordingIsNamedInTheFirstRefusal— written first, failed with the exact observed symptom (the refusal named the capture alone), passes nowTest helper extended, no assertion changed:
refusingBlobsimplements the newExistswith the same refuse-first guarantee.Closes #223