Skip to content

feat(review): a recording is judged - #227

Merged
haribo merged 3 commits into
developfrom
feat/226-a-recording-is-judged
Sep 9, 2026
Merged

feat(review): a recording is judged#227
haribo merged 3 commits into
developfrom
feat/226-a-recording-is-judged

Conversation

@haribo

@haribo haribo commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • ADR 0023 (validated): a recording is judged, and the judgment lands on the recording on screen — one edition, one variant; statuses derived from stored facts (to-review, accepted, refused), mandatory remark on refusal, symmetric take-backs; every push brings new bytes and a new to-review recording; the recording counts in the case derivation like a capture
  • Server: migration 00020 (recording_judgments, exercised Up→Down→Up), POST/DELETE /recordings/{id}/judgment, grid recordings expose status and the standing refusal; an edition carrying recordings reopens its settled cases (deliberately narrow — moved still never rises); SaveReview re-derives after releasing onto the latest edition, since the caught-up edition can carry unjudged videos; the video is served with its sniffed content type (WebM/MP4) so the browser streams instead of downloading
  • Web (validated mockup): clicking a recording opens the carousel on a player view with its own address (/recordings/:variantId); the pair judges the video, refuse opens the remark sheet (no variant ticks, its own title); enters the steps, from the first step returns to the video, ↑↓ switch variants, space belongs to the player

Test plan

  • Design tests named in docs/design/product.md §3: TestARecordingIsJudgedAndTheCaseFollows, TestANewEditionResetsTheRecordingToReview
  • Carousel specs: player + judge, refuse sheet, take-back with standing refusal, the walk; grid spec: the cell opens the carousel and downloads nothing
  • e2e: "the recording is judged in the carousel, and a new push resets it (let the reviewer judge the recording #226)"
  • Full gates: gen-check, be-check, be-test (12), db-test, fe-check, fe-test (106), fe-test-e2e (63)
  • Screenshots of the three states, both themes, validated

Existing tests modified (flagged): the grid spec "leaves the recording without a verdict ring" carried ADR 0013's superseded premise — it becomes "opens the recording in the carousel instead of downloading it"; its fixtures gain the now-required status field.

Deploy note: cases carrying recordings (prod: signing in) return to to-review on their next push — the price ADR 0023 makes explicit.

Closes #226

@haribo
haribo merged commit d8db1e8 into develop Sep 9, 2026
5 checks passed
@haribo
haribo deleted the feat/226-a-recording-is-judged branch September 9, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

let the reviewer judge the recording

1 participant