feat(review): a recording is judged - #227
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to-review,accepted,refused), mandatory remark on refusal, symmetric take-backs; every push brings new bytes and a newto-reviewrecording; the recording counts in the case derivation like a capturerecording_judgments, exercised Up→Down→Up),POST/DELETE /recordings/{id}/judgment, grid recordings exposestatusand the standingrefusal; an edition carrying recordings reopens its settled cases (deliberately narrow —movedstill never rises);SaveReviewre-derives after releasing onto the latest edition, since the caught-up edition can carry unjudged videos; the video is served with its sniffed content type (WebM/MP4) so the browser streams instead of downloading/recordings/:variantId); the pair judges the video, refuse opens the remark sheet (no variant ticks, its own title);→enters the steps,←from the first step returns to the video,↑↓switch variants, space belongs to the playerTest plan
docs/design/product.md§3:TestARecordingIsJudgedAndTheCaseFollows,TestANewEditionResetsTheRecordingToReviewExisting tests modified (flagged): the grid spec "leaves the recording without a verdict ring" carried ADR 0013's superseded premise — it becomes "opens the recording in the carousel instead of downloading it"; its fixtures gain the now-required
statusfield.Deploy note: cases carrying recordings (prod:
signing in) return toto-reviewon their next push — the price ADR 0023 makes explicit.Closes #226