Skip to content

fix(review): a push without provenance still turns moved - #231

Merged
haribo merged 1 commit into
developfrom
fix/230-a-push-without-provenance-is-blind-at-read
Sep 10, 2026
Merged

fix(review): a push without provenance still turns moved#231
haribo merged 1 commit into
developfrom
fix/230-a-push-without-provenance-is-blind-at-read

Conversation

@haribo

@haribo haribo commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Production bug (a push without provenance is measured at intake and blind at read #230, vilajo): repushed captures carried movedPixels up to 246991 yet read accepted — intake keys its comparison on the empty environment ("") while the read derivation joined references with c.provenance->>'environmentId', which is SQL NULL for a provenance-less push and matches nothing
  • CaseCaptureFacts now coalesces to '', the same key the stamping side already writes (StampCaptureReference coalesced from day one), so both sides speak the same empty-environment key
  • Statuses are derived at read (ADR 0021): the vilajo captures turn moved on deploy, no data repair needed

Test plan

  • TestAPushWithoutProvenanceStillTurnsMoved — written first, failed with the exact prod symptom (status = "accepted" with 40 moved pixels), passes now
  • Swept for other uncoalesced provenance->>'environmentId' reads: none
  • Full gates: gen-check, be-check, be-test (12), db-test, fe-test-e2e (63)

No existing test modified.

Closes #230

@haribo
haribo merged commit 324fa11 into develop Sep 10, 2026
4 checks passed
@haribo
haribo deleted the fix/230-a-push-without-provenance-is-blind-at-read branch September 10, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a push without provenance is measured at intake and blind at read

1 participant