Skip to content

fix(web): let the player fill the stage #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haribo merged 1 commit into from
Sep 10, 2026
Merged

fix(web): let the player fill the stage #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/web/e2e/capture.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ test('signing in, kept as evidence', async ({ page, browser }) => {
const recordings: Recording[] = []
for (const theme of ['light', 'dark'] as const) {
const filming = await browser.newContext({
recordVideo: { dir: test.info().outputPath('videos') },
// Pinned to the viewport: without a size Playwright scales the frame
// down to fit 800×800, and the pushed video arrives small (#232).
recordVideo: { dir: test.info().outputPath('videos'), size: { width: 1280, height: 720 } },
viewport: { width: 1280, height: 720 },
storageState: { cookies: [], origins: [] },
colorScheme: theme,
baseURL: test.info().project.use.baseURL,
Expand Down
5 changes: 4 additions & 1 deletion apps/web/src/widgets/capture-carousel/CaptureCarousel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,11 +455,14 @@ onBeforeUnmount(() => window.removeEventListener('keydown', onKey))
<!-- The player: the browser's own controls, streaming the sniffed
content type. The pair below judges these exact bytes (ADR 0023). -->
<span v-if="rec" class="flex h-full w-full min-h-0 items-center justify-center">
<!-- Unlike a capture, the video scales up: nothing pixel-accurate is
being judged here (ADR 0013), and a small source in a big stage
is just hard to watch (#232). object-contain letterboxes. -->
<video
:src="`/api/projects/${slug}/recordings/${rec.id}`"
controls
:aria-label="`recording — ${variant?.label}`"
class="max-h-full max-w-full border border-slate-300 bg-white dark:border-slate-600 dark:bg-slate-900"
class="h-full w-full border border-slate-300 bg-white object-contain dark:border-slate-600 dark:bg-slate-900"
></video>
</span>
</div>
Expand Down
Loading