feat(review): say when somebody else is reviewing a case - #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pagehidekeepalive both), and a silent lock expires on its own after two minutes (OZALID_LOCK_WINDOW, lazy — expiry is read, never written)GET caseexposesheld {by, name, since}, the page wears a neutral eye pill, the reader's carousel goes inert with "X is reviewing this case — read-only until they let go"SaveReview, comment and recording judgments answer423naming the holder; the dev's moves — track, deliver, discard — pass untouched (§7 already protects the bytes)case_locks), exercised Up→Down→Up; the expiry window answered inproduct.md§11 (validated)Test plan
TestAHeldCaseRefusesAnotherReviewersVerdict,TestASilentLockExpiresOnItsOwn,TestTwoReviewersRaceForTheLock— the race truly parallelExisting test modified (flagged): the #70 expired-session e2e resumes the verdict as another account — it now releases the lock first, since a held case rightly answers 423 to anyone but the holder.
Closes #95